-
-
Notifications
You must be signed in to change notification settings - Fork 355
[Icons] explain svg size #2670
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dbu
wants to merge
1
commit into
symfony:2.x
Choose a base branch
from
dbu:icons-size
base: 2.x
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[Icons] explain svg size #2670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smnandre
reviewed
Apr 4, 2025
Comment on lines
+86
to
+100
.. note:: | ||
|
||
Without size instructions, ``<svg>`` elements will be dynamically sized by the browser. | ||
For icons, we therefore recommend to explicitly set the size. This can be done with a | ||
CSS class or a height attribute in pixels, with variables of your CSS framework or using | ||
``em`` to set the size in relation to the font size of the current element. | ||
|
||
Note that it is enough to specify the height, the width will be adjusted accordingly: | ||
|
||
.. code-block:: twig | ||
|
||
{{ ux_icon('user-profile', {style: 'height: 1em;'}) }} | ||
|
||
For a consistent look, you might want to set the size through a | ||
:ref:`default attribute <icons_default_attributes>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
.. note:: | |
Without size instructions, ``<svg>`` elements will be dynamically sized by the browser. | |
For icons, we therefore recommend to explicitly set the size. This can be done with a | |
CSS class or a height attribute in pixels, with variables of your CSS framework or using | |
``em`` to set the size in relation to the font size of the current element. | |
Note that it is enough to specify the height, the width will be adjusted accordingly: | |
.. code-block:: twig | |
{{ ux_icon('user-profile', {style: 'height: 1em;'}) }} | |
For a consistent look, you might want to set the size through a | |
:ref:`default attribute <icons_default_attributes>`. | |
Icon Sizes | |
~~~~~~~~ | |
.. note:: | |
``<svg>`` elements will be dynamically sized by the browser. | |
For icons, we therefore recommend to explicitly set the size. | |
To align icons naturally with surrounding text and inherit font sizing, use ``em`` | |
units. This works well for buttons, links, or inline text. Defining the height alone | |
is sufficient—the width will scale proportionally: | |
.. code-block::twig | |
{# Twig function #} | |
{{ ux_icon('user-profile', {style: 'height: 1em;'}) }} | |
{# HTML syntax #} | |
<twig:ux:icon name="profile" style="height: 1em;" /> | |
If your project uses a CSS framework like Tailwind or Bootstrap, prefer their | |
sizing utilities for consistency and theming: | |
.. code-block::twig | |
{# Twig function #} | |
{{ ux_icon('bi:chat', {class: 'size-4'}) }} | |
{# HTML syntax #} | |
<twig:ux:icon name="bi:chat" class="size-4" /> | |
To keep your design consistent and easily adjustable, consider defining a :ref:default attribute <icons_default_attributes>. This allows you to control the size of all your icons from a single place. | |
wdyt?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
better explain that icons need their size specified, and explain how to do that.