Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new QuillJs component #983

Open
wants to merge 4 commits into
base: 2.x
Choose a base branch
from
Open

Conversation

Ehyiah
Copy link

@Ehyiah Ehyiah commented Jul 2, 2023

Q A
Bug fix? no
New feature? yes
Tickets N/A
License MIT

This PR try to make a WYSIWYG into a new Symfony UX component, the famous QuillJs https://quilljs.com/

Usage is pretty simple, just add a QuillType as any regular FormType to get the most simple WYSIWYG.
Or use the configurations options to add other possible options.

It also comes with an EasyAdmin integration by creating a specific QuillAdminField.

Also Currently adding some features not availables out of the box by quill like custom image upload endpoint if you don't want images to be stored as base64 in your database.

Would you like to see this component be added into symfony UX ?

@ahmedyakoubi
Copy link

Nice job man but I have other thoughts about QuillJs. quilljs is not well maintained and if we have to make it happen we need to wait until version 2 is released and see where things are going. Also, I'd prefer to go with something smaller (size) and more potent like Lexical.

@Ehyiah
Copy link
Author

Ehyiah commented Jul 2, 2023

Thank you :-)
Pretty happy you found it great, this is my first try contributing in symfony ecosystem.

And hat was one of my concern too when I choose to start this WYSIWYG component with QuillJs.
Version 2.0 seems to be still in developpement.

And Lexical seems pretty nice too.

I'm totally open to make it with another tool if the majority prefer it.

@weaverryan
Copy link
Member

Ah yea, I see that Quill tagged 2.0.0.dev0 5 years ago!

I have not used Lexical, but it looks high quality, is backed by Facebook. On #1 (yes, issue 1!) some other options were discussed.

Also, there is https://trix-editor.org/ - which is from the same people as Stimulus / Turbo. I would probably vote for trying Trix first, then Lexical if Trix is lacking in some way.

@smnandre
Copy link
Member

smnandre commented Jul 6, 2023

I spent a lot of time comparing various RTE last couple of years and.. in my humble opinion the most updated/professional one is TipTapDev.

It allows more complex content structures like editor.js but even in its simplest form it's already a great / profesional editor with advanced capacities.

I'd love to see it integrated in Symfony UX

@Ehyiah
Copy link
Author

Ehyiah commented Jul 11, 2023

I'll take a few days to try some of these, at this point I keep in mind 4 alternatives to QuillJs :

Lexical which seems pretty complete,
TipTap seems pretty well (also very complete and configurable, i like this point).
Trix seems very easy to use and to implement (I think), but maybe lack of configurability at first glance).
suneditor looks very nice also (complete and configurable and very well documented)

This is going to be complicated, but at this moment, my preference goes to suneditor.

Maybe we could start a polling ? What do you think ?

@WebMamba
Copy link
Collaborator

Tiptap already has a Laravel integration: https://tiptap.dev/installation/php. And like what they did by wrapping everything in a component:

 <x-editor
  wire:model="foo"
  wire:poll.10000ms="autosave"
></x-editor>

It can be cool to endup with something like this:

 <twig:editor 
   wire:model="foo"
  wire:poll.10000ms="autosave"
  ></x-editor>

The 4 alternatives look good, but Lexical and TipTap have stronger communities AND GOOD DOCUMENTATION. suneditor is a no-go for me for these two reasons.

@weaverryan
Copy link
Member

Both tiptap and lexical look great. Both have a ton of GH stars and are very active. Both have MIT licenses. As someone who hasn't used either, if I had to pick one, I'd pick tiptap. Its docs/site look better and it's initialization looks clean.

@Ehyiah
Copy link
Author

Ehyiah commented Jul 12, 2023

Well, looks like we have 2 finalists.
I'm going to have a deeper look into these 2, then start a new component from one of these :-)

Lets get back to work again !

@simondaigre
Copy link
Contributor

Quill 2.0 is available. Maybe we can reconsider this PR ?

@Ehyiah
Copy link
Author

Ehyiah commented Apr 19, 2024

I'm working on it for a few weeks/months already,
The bundle is already compatible with quill v2 (release candidate 5 atm) with some new things.
I will bump the quill to the 2.0 release in the next few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants