Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow PHPStan 2 #12

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Allow PHPStan 2 #12

wants to merge 1 commit into from

Conversation

samsonasik
Copy link
Member

@ondrejmirtes
Copy link

Please read the upgrading guide before you attempt to upgrade.

@ondrejmirtes
Copy link

The upgrading guide says:

Please switch to PHPStan 2.0 in a new major version of your extension. It's not feasible to try to support both PHPStan 1.x and PHPStan 2.x with the same extension code.

You can definitely get closer to supporting PHPStan 2.0 without increasing major version by solving reported deprecations and other issues by analysing your extension code with PHPStan & phpstan-deprecation-rules & Bleeding Edge, but the final leap and solving backward incompatibilities should be done by requiring "phpstan/phpstan": "^2.0" in your composer.json, and releasing a new major version.

@ondrejmirtes
Copy link

@samsonasik
Copy link
Member Author

Thank you, I will look on dependency tree, as it require-dev-ing rector, which rector still require phpstan 1.

I will check if it possibly check on symplify/phpstan-rules first, with temporary remove rector dependency to allow its phpstan extensions first...

@samsonasik samsonasik marked this pull request as draft November 11, 2024 09:57
@carlos-granados
Copy link

I checked this repo and after upgrading to PHPStan 2.0 no further changes are needed, al PHPStan and PHPUnit tests pass

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants