Support PHPStan 2.0 #144
Support PHPStan 2.0 #144
Conversation
|
I thought I needed a |
zonuexe
force-pushed
the
migrate/phpstan-2.0
branch
from
9dce5c1
to
c823f54
Compare
|
All tests pass in my environment. 
|
| /** | ||
| * @param FileNode $node | ||
| * @return string[] | ||
| */ | ||
| public function processNode(Node $node, Scope $scope): array |
There was a problem hiding this comment.
The @param should remain, so IDE can fill the methods on $node
There was a problem hiding this comment.
Ok, that doesn't make sense for an IDE that supports generics, but let's restore it.
There was a problem hiding this comment.
My lattest PHPStorm still doesn't. What IDE do you use?
Without param type:
With param type:
zonuexe
force-pushed
the
migrate/phpstan-2.0
branch
from
c823f54
to
e66aa45
Compare
zonuexe
force-pushed
the
migrate/phpstan-2.0
branch
from
e66aa45
to
7986458
Compare
|
I have to hurry up and catch a long-distance bus now, but I've finished what I can do. |
| use Symplify\RuleDocGenerator\Contract\DocumentedRuleInterface; | ||
| use Symplify\RuleDocGenerator\ValueObject\CodeSample\CodeSample; | ||
| use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; | ||
|
|
||
| /** | ||
| * @implements <FileNode> |
There was a problem hiding this comment.
The autocompletion does not work because this should say @implements Rule<FileNode>.
| @@ -17,7 +17,7 @@ | |||
| use Symplify\RuleDocGenerator\ValueObject\RuleDefinition; | |||
|
|
|||
| /** | |||
| * @implements <FileNode> | |||
| * @implements Node<FileNode> | |||
There was a problem hiding this comment.
Yes. Running PHPStan on the code will report that.
All packages that are not compatible with PHPStan 2.0 have been temporarily removed.
refs rectorphp/rector#8815