#54 Updater flow refactor and improvements #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Exceptions will now be presented in a MessageBox even though neither logging or console is enabled, after they have been presented they will be rethrown.
Cleaned up error handling and execution flow, also removed some redundant logic.
Changed it from being dependant on a command line argument passed in by the updater instead of being dependant on an invalid or timeout of pipe connection. The latter did not work well with the recent changes in the pipe management either.
…update right away
…s not currently running
#54 Changes after QA
robinwassen
added a commit
that referenced
this pull request
Feb 18, 2016
#54 Updater flow refactor and improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes has been code reviewed and QA-tested by @amc0 and @FWennerdahl.
The reason for these changes is that the Updater fail to perform updates with the error message "Could not launch cold update process" as mentioned in #54 .
It is hard to tell if these changes actually will solve the problem, but if they don't we hopefully will get enough details to solve it in the next pass on the problem.
Major changes: