Add value tracking to ConstExpr for improved union optimization #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berkaysynnada
approved these changes
Dec 8, 2024
There was a problem hiding this comment.
LGTM @gokselk. You can open this PR to upstream as well after addressing my last suggestions.
| @@ -62,11 +62,12 @@ pub struct ConstExpr { | |||
| /// Does the constant have the same value across all partitions? See | |||
| /// struct docs for more details | |||
| across_partitions: bool, | |||
| value: Option<ScalarValue> | |||
| } | |||
|
|
|||
| impl PartialEq for ConstExpr { | |||
There was a problem hiding this comment.
Can't we auto-derive PartialEq for ConstantExpr's?
There was a problem hiding this comment.
Not possible due to a Rust bug, details here: apache#13196
This reverts commit 3051cd4.
gokselk
force-pushed
the
feature/const-expr-value-tracking
branch
from
1a81628 to
f737c65
Compare
github-actions
bot
added
documentation
gokselk
force-pushed
the
feature/const-expr-value-tracking
branch
from
6cc8259 to
1917c0e
Compare
github-actions
bot
removed
documentation
|
Merged upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?