Import category position #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TheGrimmChester
commented
Nov 6, 2023
TheGrimmChester
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
TheGrimmChester
force-pushed
the
feature/import-categorie-positions
branch
5 times, most recently
from
585cf5c to
c759562
Compare
oallain
reviewed
Nov 9, 2023
|
|
||
| $this->dispatcher->dispatch(new AfterProcessingTaxonEvent($resource, $taxon)); | ||
|
|
||
| $this->entityManager->flush(); | ||
| $this->sortableManager->enableSortableEventListener(); |
There was a problem hiding this comment.
Can you move enable/disable of Doctrine event arroud le foreach ? To have only on call for all Categories.
TheGrimmChester
force-pushed
the
feature/import-categorie-positions
branch
2 times, most recently
from
a6214af to
e78610f
Compare
TheGrimmChester
force-pushed
the
feature/import-categorie-positions
branch
from
e78610f to
6744eee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.