Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add email-italic test #15

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bertho-zero
Copy link

@bertho-zero bertho-zero commented Jan 22, 2025

Hi, I added a test that shows that an email at the beginning of an italic text is not transformed correctly.

Input:

_[email protected] to contact support_

Output:

<p><a href="mailto:[email protected]">[email protected]</a> to contact support_</p>

Expected:

<p><em><a href="[email protected]">[email protected]</a> to contact support</em></p>

Gfm example:

[email protected] to contact support

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Jan 22, 2025
Copy link

github-actions bot commented Jan 22, 2025

Hi! It seems you removed the template which we require. Here are our templates (pick the one you want to use and click *raw* to see its source):

I won’t send you any further notifications about this, but I’ll keep on updating this comment, and hide it when done!

Thanks,
— bb

@wooorm
Copy link
Member

wooorm commented Jan 23, 2025

GFM works weirdly and does this one different than all other things. This cannot normally be solved. It would be solved by https://github.com/micromark/micromark-extension-gfm-autolink-literal/blob/618170c86639742036ecf666d975a6ebac5aac50/dev/lib/syntax.js#L76-L79.

@bertho-zero
Copy link
Author

Hi,

Thanks for your answer, is this something that is planned soon or is it not a priority?

@wooorm
Copy link
Member

wooorm commented Mar 3, 2025

The work here is done on a volunteer basis, or, when there’s enough funding, I get to things across the collective. This particular problem is complex. So, you can either try your hand at it, or, sponsor the projects

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👋 phase/new Post is being triaged automatically
Development

Successfully merging this pull request may close these issues.

2 participants