Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use iOS-compatible regex for autolink parsing #16

Closed
wants to merge 1 commit into from

Conversation

wenxue11
Copy link

@wenxue11 wenxue11 commented Feb 12, 2025

Initial checklist

  • I read the support docs
  • I read the contributing guide
  • I agree to follow the code of conduct
  • I searched issues and discussions and couldn’t find anything or linked relevant results below
  • I made sure the docs are up to date
  • I included tests (or that’s not needed)

Description of changes

修复ios低版本,ios16版本,正则表达式报错问题。
之前的正则,在ios低版本会报错误,[Error] SyntaxError: Invalid regular expression: invalid group specifier name。
该正则表达式包含 Safari 使用的 JavaScript 引擎不支持的语法。这通常涉及较新的功能,如后行断言或命名捕获组 。

@github-actions github-actions bot added the 👋 phase/new Post is being triaged automatically label Feb 12, 2025

This comment has been minimized.

@JounQin
Copy link
Member

JounQin commented Feb 12, 2025

Duplicate of #10

@JounQin JounQin marked this as a duplicate of #10 Feb 12, 2025
@JounQin JounQin closed this Feb 12, 2025

This comment has been minimized.

@JounQin JounQin added the 👯 no/duplicate Déjà vu label Feb 12, 2025
Copy link

Hi! Thanks for taking the time to contribute!

Because we treat pull requests as our backlog, we close duplicates to focus our work and not have to touch the same chunk of code for the same reason multiple times. This is also why we may mark something as duplicate that isn’t an exact duplicate but is closely related.

Thanks,
— bb

@github-actions github-actions bot added 👎 phase/no Post cannot or will not be acted on and removed 👋 phase/new Post is being triaged automatically labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👯 no/duplicate Déjà vu 👎 phase/no Post cannot or will not be acted on
Development

Successfully merging this pull request may close these issues.

2 participants