Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass-through authentication - DONOTMERGE #4221

Draft
wants to merge 2 commits into
base: v2.x
Choose a base branch
from

Conversation

renecannao
Copy link
Contributor

@renecannao renecannao commented May 14, 2023

A POC based on #4220

With caching_sha2_password it is possible to do pass-through authentication:
* client connects to proxysql
* proxysql retrieves the credentials and tries to connect to backend
* if connection to backend succeeds, complete the client authentication

This is still a POC
@renecannao renecannao marked this pull request as draft May 14, 2023 21:47
sha256_init_ctx (&alt_ctx);

/* For every character in the password add the entire password. */
for (unsigned char cnta = 0; cnta < 16 + alt_result[0]; ++cnta)

Check failure

Code scanning / CodeQL

Comparison of narrow type with wide type in loop condition

Comparison between [cnta](1) of type unsigned char and [... + ...](2) of wider type int.
@mirostauder
Copy link
Collaborator

Can one of the admins verify this patch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants