-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MySQL compression level variable and change default to compression level 3 #4764
Open
yashwantsahu20
wants to merge
7
commits into
v3.0
Choose a base branch
from
v3.0_compression
base: v3.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashwantsahu20
changed the title
[WIP] Added MySQL compression level variable
Added MySQL compression level variable
Nov 29, 2024
yashwantsahu20
changed the title
Added MySQL compression level variable
Add MySQL compression level variable and change default to compression level 3
Nov 29, 2024
JavierJF
requested changes
Dec 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments and changes are focused on the TAP test, there are also some suggestions. Thanks!
1. Moved monotonic_time to util 2. Now calculate_query_execution_time will return -1 incase of error. 3. Using util function for setting and getting compression variable values. 4. Added mysql_query_rules
JavierJF
reviewed
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default compression level was 6 for MySQL clients and this was making ProxySQL slower.
Following changes has been made:
For detail of issue, #4721