Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MySQL compression level variable and change default to compression level 3 #4764

Open
wants to merge 7 commits into
base: v3.0
Choose a base branch
from

Conversation

yashwantsahu20
Copy link
Collaborator

Default compression level was 6 for MySQL clients and this was making ProxySQL slower.

Following changes has been made:

  1. Made default compression level as 3.
  2. Added MySQL compression level variable

For detail of issue, #4721

@yashwantsahu20 yashwantsahu20 changed the title [WIP] Added MySQL compression level variable Added MySQL compression level variable Nov 29, 2024
@yashwantsahu20 yashwantsahu20 changed the title Added MySQL compression level variable Add MySQL compression level variable and change default to compression level 3 Nov 29, 2024
Copy link
Collaborator

@JavierJF JavierJF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments and changes are focused on the TAP test, there are also some suggestions. Thanks!

test/tap/tests/mysql-protocol_compression_level-t.cpp Outdated Show resolved Hide resolved
test/tap/tests/mysql-protocol_compression_level-t.cpp Outdated Show resolved Hide resolved
test/tap/tests/mysql-protocol_compression_level-t.cpp Outdated Show resolved Hide resolved
test/tap/tests/mysql-protocol_compression_level-t.cpp Outdated Show resolved Hide resolved
test/tap/tests/mysql-protocol_compression_level-t.cpp Outdated Show resolved Hide resolved
test/tap/tests/mysql-protocol_compression_level-t.cpp Outdated Show resolved Hide resolved
1.  Moved monotonic_time to util
2.  Now calculate_query_execution_time will return -1 incase of error.
3.  Using util function for setting and getting compression variable values.
4.  Added mysql_query_rules
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants