-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(@theme-ui/custom-properties): TS conversion #671
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing work! #670 was just merged, if you rebase on top of master we should be good to go 👍
@mxstbr Good to go 👍 |
}, | ||
"publishConfig": { | ||
"access": "public" | ||
}, | ||
"dependencies": { | ||
"pluralize": "^8.0.0" | ||
}, | ||
"devDependencies": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we discuss about dep/devDep/peerDep for those types?
Also see: #672 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for now, let's merge this and then add a task to move Theme
to @theme=ui/css
as described in #672 (comment)
Thank you for digging into this, this is awesome! 🔥
Converts custom-properties over to TS.
.idea
was added to gitignorestrict
was used for tsconfig.jsonPart of #668