Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🗃️ Delete Attachments when deleting Messages or Tickers #250

Merged

Conversation

0x46616c6b
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 21, 2023

Codecov Report

Merging #250 (a48473c) into main (ebfcee9) will increase coverage by 0.02%.
The diff coverage is 64.00%.

@@            Coverage Diff             @@
##             main     #250      +/-   ##
==========================================
+ Coverage   92.58%   92.61%   +0.02%     
==========================================
  Files          42       42              
  Lines        1847     1868      +21     
==========================================
+ Hits         1710     1730      +20     
+ Misses        114      111       -3     
- Partials       23       27       +4     
Files Coverage Δ
internal/api/tickers.go 100.00% <100.00%> (ø)
internal/storage/sql_storage.go 86.66% <57.14%> (-3.02%) ⬇️

... and 1 file with indirect coverage changes

@0x46616c6b 0x46616c6b merged commit 1c42a42 into main Oct 21, 2023
@0x46616c6b 0x46616c6b deleted the Delete-Attachments-when-deleting-Messages-or-Tickers branch October 21, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant