✨ Use HTTP API for userli user lookup #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doobry-systemli
force-pushed
the
feat/userli_api
branch
from
5f4f5b2 to
da4865a
Compare
0x46616c6b
requested changes
Apr 29, 2024
pom.xml
Outdated
| @@ -24,12 +24,36 @@ | |||
| <version>${version.keycloak}</version> | |||
| <scope>provided</scope> | |||
| </dependency> | |||
| <dependency> | |||
There was a problem hiding this comment.
These dependencies are not needed. Also, the Jakarta Sodium dependencies can be safely removed.
pom.xml
Outdated
| <dependency> | ||
| <groupId>org.projectlombok</groupId> | ||
| <artifactId>lombok</artifactId> | ||
| <version>1.18.32</version> | ||
| <scope>provided</scope> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
This can also be removed as we need the logging only for development purposes.
Comment on lines
7
to
9
| public String REALM_DOMAIN = "userliRealmDomain"; | ||
| public String BASE_URL = "userliBaseUrl"; | ||
| public String KEYCLOAK_API_TOKEN = "userliKeycloakToken"; |
There was a problem hiding this comment.
Suggested change
| public String REALM_DOMAIN = "userliRealmDomain"; | |
| public String BASE_URL = "userliBaseUrl"; | |
| public String KEYCLOAK_API_TOKEN = "userliKeycloakToken"; | |
| public final String REALM_DOMAIN = "userliRealmDomain"; | |
| public final String BASE_URL = "userliBaseUrl"; | |
| public final String KEYCLOAK_API_TOKEN = "userliKeycloakToken"; |
Constants should be final to ensure they cannot be modified.
| @@ -0,0 +1,34 @@ | |||
| package org.systemli.keycloak; | |||
There was a problem hiding this comment.
This interface only makes sense when we would expose an API in Keycloak, which we don't do. So this makes no sense here.
| .auth(keycloakApiToken) | ||
| .asResponse(); | ||
| if (response.getStatus() == 404) { | ||
| throw new WebApplicationException(response.getStatus()); |
There was a problem hiding this comment.
This exception is the only reason why we still need the Jakarta package. So I would recommend creating an exception on our own.
| @Override | ||
| @SneakyThrows | ||
| public Boolean validate(String email, String password) { | ||
| log.warn("UserliUserClientSimpleHttp validate: User with email '{}' and password '{}' tries to login", email, password); |
There was a problem hiding this comment.
Suggested change
| log.warn("UserliUserClientSimpleHttp validate: User with email '{}' and password '{}' tries to login", email, password); |
Security! :-)
There was a problem hiding this comment.
Haha ouch, this was a debugging leftover 🙈
| return ProviderConfigurationBuilder.create() | ||
| .property(Constants.REALM_DOMAIN, "Realm domain", "Limit users to this domain", ProviderConfigProperty.STRING_TYPE, "", null) | ||
| .property(Constants.BASE_URL, "Base URL", "Base URL of the API", ProviderConfigProperty.STRING_TYPE, "", null) | ||
| .property(Constants.KEYCLOAK_API_TOKEN, "Keycloak API token", "Token for the userli keycloak API", ProviderConfigProperty.STRING_TYPE, "", null) |
There was a problem hiding this comment.
Suggested change
| .property(Constants.KEYCLOAK_API_TOKEN, "Keycloak API token", "Token for the userli keycloak API", ProviderConfigProperty.STRING_TYPE, "", null) | |
| .property(Constants.API_TOKEN, "API token", "Token for the userli keycloak API", ProviderConfigProperty.STRING_TYPE, "", null) |
Would call that only API token.
0x46616c6b
approved these changes
May 6, 2024
0x46616c6b
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires systemli/userli#595