Subscribe to correct LoginEvent name #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the `last_login_time` record being updated when authenticating through the `app:users:checkpassword` command.
doobry-systemli
force-pushed
the
fix/login_event
branch
from
4907d87 to
3999816
Compare
Codecov Report
@@ Coverage Diff @@
## main #507 +/- ##
============================================
- Coverage 36.02% 36.01% -0.01%
Complexity 1137 1137
============================================
Files 185 185
Lines 4583 4584 +1
============================================
Hits 1651 1651
- Misses 2932 2933 +1
|
Fixes a deprecation warning.
doobry-systemli
force-pushed
the
fix/login_event
branch
from
4831c6e to
294fa18
Compare
0x46616c6b
reviewed
Nov 6, 2023
| $mailLocation); | ||
| $commandTester = new CommandTester($command); | ||
|
|
||
| $commandTester->execute([]); |
There was a problem hiding this comment.
I do not see any assertation here. It would be good to assert that the command returns successfully and the mocked services were called as expected.
There was a problem hiding this comment.
I changed the code logic now so that $this->loginListener->expects(self::once())->method('onLogin') is in the test function itself. Probably it's easier to follow the logic of the test that way.
I also added an assertion to make sure the execute() call succeeded, but that's not what we want to test here. We want to test whether LoginListener->onLogin() got triggered.
doobry-systemli
force-pushed
the
fix/login_event
branch
from
294fa18 to
618e974
Compare
0x46616c6b
approved these changes
Nov 6, 2023
t2d
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
last_login_timerecord being updated when authenticating through theapp:users:checkpasswordcommand.