feat(l10n): Remove URL-based localized routes, store locale in session #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doobry-systemli
force-pushed
the
feat/locale_listener
branch
from
a3e17c9 to
32ce4dd
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/EventListener/LocaleListener.php
Outdated
| if (!$request->attributes->get('_locale')) { | ||
| $preferredLanguage = $request->getPreferredLanguage($this->supportedLocales); | ||
| $locale = $preferredLanguage ?: $this->defaultLocale; | ||
| $event->setResponse(new RedirectResponse('/' . $locale . $request->getPathInfo())); |
Check failure
Code scanning / SonarCloud
HTTP request redirections should not be open to forging attacks
doobry-systemli
force-pushed
the
feat/locale_listener
branch
from
32ce4dd to
79beff2
Compare
If no locale is set yet, use the browser locale (if supported, fallback to default 'en'). If locale is already set in session, use that one. If locale is given in query string (parameter `_locale`), use that locale (if supported, fallback to default 'en').
doobry-systemli
force-pushed
the
feat/locale_listener
branch
from
79beff2 to
5d17d6f
Compare
doobry-systemli
changed the title
0x46616c6b
force-pushed
the
feat/locale_listener
branch
from
494e293 to
5d17d6f
Compare
|
0x46616c6b
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If no locale is set yet, use the browser locale (if supported, fallback to default 'en').
If locale is already set in session, use that one.
If locale is given in query string (parameter
_locale), use that locale (if supported, fallback to default 'en').