Fix persistence of hasMailCrypt attribute #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y3n4
force-pushed
the
align-mailcrypt-handler
branch
from
a49cab1 to
adabe32
Compare
y3n4
requested review from
0x46616c6b,
doobry-systemli and
t2d
as code owners
y3n4
force-pushed
the
align-mailcrypt-handler
branch
from
9b6f165 to
d46b34f
Compare
0x46616c6b
approved these changes
Oct 18, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently UserCheckPasswordCommand only creates a secretbox for the user if mailcrypt is enforced for all users, but does not enable the users mailCrypt property.
RegistrationHandler gets it right.
To fix UserCheckPasswordCommand without having to load EntityManager into UserCheckPasswordCommand, enabling the attribute should be done in mailCryptKeyHandler.
(Ideally, creating the secretbox and setting the $user->mailCrypt property should happen in the same function but this is just a small fix)