Replace smarty fetch() call with CRM_Utils_String::parseOneOffStringThroughSmarty()
#53
+17
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensschuppe
requested changes
Feb 24, 2025
|
i see. will add some comments with further questions |
svenow
commented
Feb 25, 2025
CRM/Moregreetings/Form/Settings.php
Outdated
| @@ -163,7 +163,7 @@ public static function validateSmarty($smartyValue) { | |||
|
|
|||
There was a problem hiding this comment.
i guess, this can be removed as well as it would only be invoked in $smarty->fetch() and parseOneOffStringThroughSmarty (as seen in the code) registers its own error handler?
There was a problem hiding this comment.
This is being referenced as a form rule here:
So the rendering within that method should be adjusted as well (or refactored to use a single render method)
…fStringThroughSmarty removed obsolete smarty occurences and related code increased version of civicrm docker image to 5.75 in order to be able to use CRM_Utils_String::parseOneOffStringThroughSmarty
svenow
force-pushed
the
replace-smarty-fetch
branch
from
62620c4 to
af7c691
Compare
jensschuppe
requested changes
Feb 25, 2025
rephrased comment about necessary civicrm version in phpunit workflow file
|
With enough test feedback this should go into a |
jensschuppe
approved these changes
Feb 25, 2025
jensschuppe
changed the title
fetch() call with CRM_Utils_String::parseOneOffStringThroughSmarty()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced smarty
fetch()call withCRM_Utils_String::parseOneOffStringThroughSmartysystopia-reference: 27391