review: methods name

t0team · Apr 11, 2023 · f96dc5b · f96dc5b
1 parent 16d8ef5
commit f96dc5b
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 28 deletions.
diff --git a/src/Controllers/Form/Group.php b/src/Controllers/Form/Group.php
@@ -22,19 +22,17 @@ public static function make(?string $title = null): Group
         return new self($title);
     }
 
-    public function addInput($input): Group
+    public function input(Input $input): Group
     {
-        if ($input instanceof Input) {
-            $this->inputs[] = $input->get();
-        }
+        $this->inputs[] = $input->get();
 
         return $this;
     }
 
-    public function addInputs(array $inputs): Group
+    public function inputs(array $inputs): Group
     {
         foreach ($inputs as $input) {
-            $this->addInput($input);
+            $this->input($input);
         }
 
         return $this;

diff --git a/src/Controllers/Makers/FormMaker.php b/src/Controllers/Makers/FormMaker.php
@@ -27,7 +27,7 @@ public function __construct(string $routeNameOrUrl, array $routeNeeded, string $
         return $this;
     }
 
-    public function addGroup(Group $group): FormMaker
+    public function group(Group $group): FormMaker
     {
         $this->groups[] = $group->get();
 

diff --git a/src/Controllers/Makers/TableMaker.php b/src/Controllers/Makers/TableMaker.php
@@ -26,17 +26,17 @@ public function __construct(array $headers, array $config)
         return $this;
     }
 
-    public function addHeader(string $key, string $label): TableMaker
+    public function header(string $key, string $label): TableMaker
     {
         $this->headers[$key] = $label;
 
         return $this;
     }
 
-    public function addHeaders(array $headers): TableMaker
+    public function headers(array $headers): TableMaker
     {
         foreach ($headers as $key => $label) {
-            $this->addHeader($key, $label);
+            $this->header($key, $label);
         }
 
         return $this;
@@ -48,38 +48,38 @@ public function paginate(LengthAwarePaginator $paginate, callable $mapForRows =
 
         $this->rows = [];
         if ($mapForRows) {
-            $this->addRows($paginate->map($mapForRows));
+            $this->rows($paginate->map($mapForRows));
         } else {
-            $this->addRows($paginate);
+            $this->rows($paginate);
         }
 
         return $this;
     }
 
-    public function addAction(Button $button): self
+    public function action(Button $button): self
     {
         $this->actions[] = $button->get();
 
         return $this;
     }
 
-    public function addRows($rows): self
+    public function rows($rows): self
     {
         foreach ($rows as $row) {
-            $this->addRow($row);
+            $this->row($row);
         }
 
         return $this;
     }
 
-    public function addRow($row): self
+    public function row($row): self
     {
         if (!is_array($row)) {
             $row = $row->toArray();
         }
 
         if (isset($row[0]) && (is_array($row[0]) || is_object($row[0]))) {
-            $this->addRows($row);
+            $this->rows($row);
         } else {
             $this->rows[] = $row;
         }

diff --git a/src/Traits/InputTrait.php b/src/Traits/InputTrait.php
@@ -197,24 +197,17 @@ public function step(?string $step = null): self
         return $this;
     }
 
-    public function addOption($option): self
+    public function option(Option $option): self
     {
-        if ($option instanceof Option) {
-            $this->options[] = $option->get();
-        } elseif (is_array($option)) {
-            $this->options[] = Option::make($option['label'])
-                ->value($option['value'])
-                ->selected($option['selected'] ?? false)
-                ->get();
-        }
+        $this->options[] = $option->get();
 
         return $this;
     }
 
-    public function addOptions(array $options): self
+    public function options(array $options): self
     {
         foreach ($options as $option) {
-            $this->addOption($option);
+            $this->option($option);
         }
 
         return $this;