Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise default leaky bucket capacity #597

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Raise default leaky bucket capacity #597

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),

## [Unreleased]

*Nothing yet.*
### Changed

* The default leaky bucket capacity has changed from 300mb to 500mb, allowing for more downloads to go through. The drain rate and overflow limit are unchanged (5mb/minute and 100mb respectively).

## [1.3.6] - July 10, 2024

Expand Down
4 changes: 2 additions & 2 deletions common/config/conf_main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,9 +115,9 @@ func NewDefaultMainConfig() MainRepoConfig {
BurstCount: 10,
Buckets: RateLimitBucketsConfig{
Downloads: RateLimitDownloadBucketConfig{
CapacityBytes: 314572800, // 300mb
CapacityBytes: 524288000, // 500mb
DrainBytesPerMinute: 5242880, // 5mb
OverflowLimitBytes: 104857600, // 10mb
OverflowLimitBytes: 104857600, // 100mb
},
},
},
Expand Down
4 changes: 2 additions & 2 deletions config.sample.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,14 +502,14 @@ rateLimit:
# will use the authenticated entity as the subject - either a user or remote server.
downloads:
# The maximum size of each bucket.
capacityBytes: 314572800 # 300mb default
capacityBytes: 524288000 # 500mb default
# The number of bytes to "drain" from the bucket every minute.
drainBytesPerMinute: 5242880 # 5mb default
# The number of bytes a requester can go over the capacity, once. This is used to give some
# buffer to allow a single file to be downloaded when the caller is near the limit. This
# should be set to either your max remote download size or 30% of the capacityBytes, whichever
# is smaller.
overflowLimitBytes: 104857600 # 100mb default
overflowLimitBytes: 104857600 # 100mb default (the same as the default remote download maxBytes)


# Identicons are generated avatars for a given username. Some clients use these to give users a
Expand Down
Loading