Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tips for contributing, update State article #487

Merged
merged 13 commits into from
Dec 23, 2023

Conversation

netnef
Copy link
Contributor

@netnef netnef commented Dec 16, 2023

For the State article, I made these changes:

  • Convert the layout to a table (lmk if you don't like it)
  • Update the info to match the latest progress
  • Add links/issues to some features for reference

Preview: https://netnef.github.io/wiki/state/

@sharpenedblade
Copy link
Contributor

There is work in progress support for custom graphics on the Touch Bar.

Its not really WIP anymore, it should just say that its supported

Trackpad 🟡 Partially working

It should be marked as working, but leave the note there. Same with audio.

@AdityaGarg8
Copy link
Member

Wi-Fi and Bluetooth drivers are upstreamed. Also, Bluetooth is partially working for BCM4377 devices. On other devices too, it's not very stable.

Copy link
Member

@AdityaGarg8 AdityaGarg8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See latest comment

@AdityaGarg8
Copy link
Member

I added a commit in your pr so that there is no clash.

Copy link
Member

@Redecorating Redecorating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having a table here is much better

docs/state.md Outdated Show resolved Hide resolved
docs/state.md Outdated Show resolved Hide resolved
docs/state.md Outdated Show resolved Hide resolved
docs/state.md Outdated Show resolved Hide resolved
docs/state.md Outdated Show resolved Hide resolved
@netnef
Copy link
Contributor Author

netnef commented Dec 16, 2023

I updated the State article to address all of the comments here. I also added "Thunderbolt" to the features list.

Preview: https://netnef.github.io/wiki/state/

There's one last thing I wanted to ask about:

Some models have deadzones on the edges of their trackpads where swipes along the trackpad that start in these deadzones will not be registered.

Is this still an issue? Is there a list of affected models anywhere?

@AdityaGarg8
Copy link
Member

I updated the State article to address all of the comments here. I also added "Thunderbolt" to the features list.

Preview: https://netnef.github.io/wiki/state/

There's one last thing I wanted to ask about:

Some models have deadzones on the edges of their trackpads where swipes along the trackpad that start in these deadzones will not be registered.

Is this still an issue? Is there a list of affected models anywhere?

Tbh not enough feedback there by the users. Today only mbp 16,2 got fixed.

@netnef
Copy link
Contributor Author

netnef commented Dec 16, 2023

Ok, then we can leave the notice there I guess. But I would still leave the status as "working" because for most models it works as well as it possibly can (using libinput, at least). We should probably also add details about how to use the Synaptics driver (with a disclaimer that it's unsupported and requires using deprecated X11 instead of Wayland). smileBeda provided instructions in the Discord for this. We can maybe paste those into a gist or wiki article.

@AdityaGarg8
Copy link
Member

The gist is already in the wiki, you can put working as well

@AdityaGarg8
Copy link
Member

Also, fix the lint errors please

@netnef
Copy link
Contributor Author

netnef commented Dec 18, 2023

The gist is already in the wiki, you can put working as well

Do you have a link to that so I can include it here?

@AdityaGarg8
Copy link
Member

https://wiki.t2linux.org/#guides-and-similar

I don't think we need to put it here though. But status as working should be put.

@netnef
Copy link
Contributor Author

netnef commented Dec 19, 2023

The reason I think we should reference it here is because of the note we have added to it:

Works, but isn't as great as on macOS

On the other wiki page you linked, it says that you can obtain this:

Implement macOS-like Keyboard and trackpad experience

I don't think adding a casual mention to it would hurt. Something like this:

Works, but isn't as great as on macOS (no force touch or palm rejection). Some models have deadzones on the edges of their trackpads where swipes along the trackpad that start in these deadzones will not be registered. Using Synaptics + X11 as per this guide could make it feel more like macOS, but comes at the cost of using a legacy display server (X11) instead of Wayland, potentially exposing other issues, like blurry display scaling.

Let me know what you think.

@AdityaGarg8
Copy link
Member

AdityaGarg8 commented Dec 20, 2023

The reason I think we should reference it here is because of the note we have added to it:

Works, but isn't as great as on macOS

On the other wiki page you linked, it says that you can obtain this:

Implement macOS-like Keyboard and trackpad experience

I don't think adding a casual mention to it would hurt. Something like this:

Works, but isn't as great as on macOS (no force touch or palm rejection). Some models have deadzones on the edges of their trackpads where swipes along the trackpad that start in these deadzones will not be registered. Using Synaptics + X11 as per this guide could make it feel more like macOS, but comes at the cost of using a legacy display server (X11) instead of Wayland, potentially exposing other issues, like blurry display scaling.

Let me know what you think.

I leave this to other maintainers @Redecorating @sharpenedblade

@sharpenedblade
Copy link
Contributor

https://gist.github.com/smileBeda/f0452f0d7f1f6d8aa772603411f7876f

This config doesnt seem to be doing anything that cant be done with libinput, we should try to get it working on wayland before puting this on the wiki (once its on the wiki people are going to use it and we "have" to support them). touchpad preasure and palm rejection is supported, we just need to set the quirks, the touchpad edge bug is fixed with this commit.

We can merge this now and change it later, or wait for proper libinput support. @Redecorating

Copy link
Member

@AdityaGarg8 AdityaGarg8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this after addressing all this?

docs/state.md Show resolved Hide resolved
docs/contribute.md Outdated Show resolved Hide resolved
@netnef
Copy link
Contributor Author

netnef commented Dec 22, 2023

https://gist.github.com/smileBeda/f0452f0d7f1f6d8aa772603411f7876f

This config doesnt seem to be doing anything that cant be done with libinput, we should try to get it working on wayland before puting this on the wiki (once its on the wiki people are going to use it and we "have" to support them). touchpad preasure and palm rejection is supported, we just need to set the quirks, the touchpad edge bug is fixed with this commit.

We can merge this now and change it later, or wait for proper libinput support. @Redecorating

The config is already on the wiki: https://wiki.t2linux.org/#guides-and-similar

Perhaps we should clarify that it's unsupported by the t2linux maintainers there.

@netnef
Copy link
Contributor Author

netnef commented Dec 23, 2023

I updated two pages to address concerns from @sharpenedblade. Let me know what you think.

@sharpenedblade
Copy link
Contributor

sharpenedblade commented Dec 23, 2023

The deadzone problem was fixed a few days ago, we can merge once thats removed from the touchpad section

@netnef
Copy link
Contributor Author

netnef commented Dec 23, 2023

I removed the deadzones remark. @AdityaGarg8 are we good to merge?

@AdityaGarg8
Copy link
Member

Looks like we are

@AdityaGarg8 AdityaGarg8 merged commit d82dec9 into t2linux:master Dec 23, 2023
1 check passed
@netnef netnef deleted the patch-1 branch December 23, 2023 06:04
@netnef
Copy link
Contributor Author

netnef commented Dec 23, 2023

👍 Thank you all for the help. Glad we got these pages updated. Long overdue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants