-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tips for contributing, update State article #487
Conversation
Its not really WIP anymore, it should just say that its supported
It should be marked as working, but leave the note there. Same with audio. |
Wi-Fi and Bluetooth drivers are upstreamed. Also, Bluetooth is partially working for BCM4377 devices. On other devices too, it's not very stable. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See latest comment
I added a commit in your pr so that there is no clash. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
having a table here is much better
I updated the State article to address all of the comments here. I also added "Thunderbolt" to the features list. Preview: https://netnef.github.io/wiki/state/ There's one last thing I wanted to ask about:
Is this still an issue? Is there a list of affected models anywhere? |
Tbh not enough feedback there by the users. Today only mbp 16,2 got fixed. |
Ok, then we can leave the notice there I guess. But I would still leave the status as "working" because for most models it works as well as it possibly can (using libinput, at least). We should probably also add details about how to use the Synaptics driver (with a disclaimer that it's unsupported and requires using deprecated X11 instead of Wayland). smileBeda provided instructions in the Discord for this. We can maybe paste those into a gist or wiki article. |
The gist is already in the wiki, you can put working as well |
Also, fix the lint errors please |
Do you have a link to that so I can include it here? |
https://wiki.t2linux.org/#guides-and-similar I don't think we need to put it here though. But status as working should be put. |
The reason I think we should reference it here is because of the note we have added to it:
On the other wiki page you linked, it says that you can obtain this:
I don't think adding a casual mention to it would hurt. Something like this:
Let me know what you think. |
I leave this to other maintainers @Redecorating @sharpenedblade |
This config doesnt seem to be doing anything that cant be done with libinput, we should try to get it working on wayland before puting this on the wiki (once its on the wiki people are going to use it and we "have" to support them). touchpad preasure and palm rejection is supported, we just need to set the quirks, the touchpad edge bug is fixed with this commit. We can merge this now and change it later, or wait for proper libinput support. @Redecorating |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this after addressing all this?
The config is already on the wiki: https://wiki.t2linux.org/#guides-and-similar Perhaps we should clarify that it's unsupported by the t2linux maintainers there. |
I updated two pages to address concerns from @sharpenedblade. Let me know what you think. |
The deadzone problem was fixed a few days ago, we can merge once thats removed from the touchpad section |
I removed the deadzones remark. @AdityaGarg8 are we good to merge? |
Looks like we are |
👍 Thank you all for the help. Glad we got these pages updated. Long overdue. |
For the State article, I made these changes:
Preview: https://netnef.github.io/wiki/state/