Automate firmware #558
Merged
Automate firmware #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaGarg8
requested changes
Jul 11, 2024
sharpenedblade
force-pushed
the
automate-firmware
branch
from
74a69e8 to
1fc921e
Compare
|
You've repeated "Detected Linux" and "Detected macOS". You probably want to remove them. L908 and L816 |
Fixed |
|
There are still some functions that you have not excluded in no interactive. Eg: the one asking to keep firmware in Efi or not when option 1 is chosen on Linux. Can you review the whole script? |
|
Fixed, thats the last |
|
|
|
Please do proper testing of the script. |
It should work now. I only tested it on linux though. |
|
This one still doesn't work |
|
Also you may add your Copyright at the top if you want. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This attempts to get the firmware from the macos apfs partition. If it fails for any reason, boot continues normally.