snipeit: Bugfix in initcontainer

[lausser]

Hi,
sh -c find /var/www/html/..... does not what it was intended here. Actually, the command executed here is simply sh -c find, the rest is ignored. find and all it's parameters should be in quotes, so that the -c has only one argument.
I replaced this simply by chown -R ..., which has the same effect. I don't think wrapping everything in sh -c "command arg arg arg" is necessary.
It solves issues #150 and #127.

Also, the init container definition used the hardcoded path /var/www/html/storage/framework/sessions. I replaced it with .Values.persistence.sessions.mountPath, like it is done in the main container.

[mschmidt291]

Hi Gerhard, thanks for the PR.
I see the issue. But can you please keep using the find command in your PR and not chown?
Background: When using plain chown on the complete sessions folder, it will take a very long time for the container to be ready, because of that we used the find command, which only changes ownership of files in the sessions folder which are not currently owned by the given user.

[lausser]

Tested with

      initContainers:
        - name: config-testdata
          image: busybox
          command: ["sh", "-c", "touch {{ .Values.persistence.sessions.mountPath }}/some_crap"]
          volumeMounts:
            - name: data
              mountPath: {{ .Values.persistence.sessions.mountPath }}
              subPath: {{ .Values.persistence.sessions.subPath }}
        - name: show-testdata
          image: busybox
          command: ["sh", "-c", "ls -l {{ .Values.persistence.sessions.mountPath }}"]
          volumeMounts:
            - name: data
              mountPath: {{ .Values.persistence.sessions.mountPath }}
              subPath: {{ .Values.persistence.sessions.subPath }}
        - name: config-data
          image: busybox
          command: ["sh", "-c", "find {{ .Values.persistence.sessions.mountPath }} -not -user 1000 -exec chown 1000 {} \\+"]
          volumeMounts:
            - name: data
              mountPath: {{ .Values.persistence.sessions.mountPath }}
              subPath: {{ .Values.persistence.sessions.subPath }}
        - name: show-testdata2
          image: busybox
          command: ["sh", "-c", "ls -l {{ .Values.persistence.sessions.mountPath }}"]
          volumeMounts:
            - name: data
              mountPath: {{ .Values.persistence.sessions.mountPath }}
              subPath: {{ .Values.persistence.sessions.subPath }}

Result:

:~/git/helm-charts$ kubectl -n snipe logs -f pod/snipe-snipeit-6d7989fd6b-26sp7 -c show-testdata
total 0
-rw-r--r--    1 root     root             0 Apr 28 09:21 some_crap
:~/git/helm-charts$ kubectl -n snipe logs -f pod/snipe-snipeit-6d7989fd6b-26sp7 -c show-testdata2
total 0
-rw-r--r--    1 1000     root             0 Apr 28 09:21 some_crap

[lausser]

I didn't notice that the changed code did not get properly pushed earlier today.

[mschmidt291]

@lausser Looks good to me. Please raise the Chart version in the Chart.yaml to a BugFix release and then i am happy to merge

[trollr]

Same issue here :( Will the PR be resolved in the next few minutes? I could use that very well now ^^

[trollr]

Thank you :) @mschmidt291 @lausser

Good Job 👍