Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added resizing ability to columns #897

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

Wardrop
Copy link

@Wardrop Wardrop commented Aug 29, 2017

Columns can now be resized by clicking and dragging the right-edge of a column. Had to add an additional inner element to the element to avoid unwanted clicks causing the column to sort on resize.

Addresses issue #9

@Wardrop
Copy link
Author

Wardrop commented Sep 6, 2017

I've just added a commit that fixes an issue with the new exportData functionality from #703. It assumed the raw data/hash would match one-to-one with the defined fields, which obviously can't be assumed, and breaks when there's more elements in the data hash than there is defined fields.

@gattidaniel
Copy link

Hi wardrop,
I am quite new in github, this commit is already in the solution or it is waiting for an approval or something like that'

@Wardrop
Copy link
Author

Wardrop commented Sep 7, 2017

@gattidaniel Yeah it's awaiting to be merged into the main jsGrid branch. Right now the changes I've made live only in my fork of jsGrid.

@tabalinas
Copy link
Owner

@Wardrop, thank you for the valuable contribution!
Could you please exclude /dist/* changes from the PR?

@Wardrop
Copy link
Author

Wardrop commented Sep 11, 2017

I've reverted the changes to the dist directory, which has essentially removed them from the pull request.

@leonardolb560
Copy link

Hi, how can i get this patch/commit for now? I really need this feature =)

@ranlandau
Copy link

Well? why isn't it in dist?

@Wardrop
Copy link
Author

Wardrop commented Nov 8, 2017

For those who want to use this now, you can get the updated dist files from a previous commit of mine: https://github.com/Wardrop/jsgrid/tree/a9cfe25/dist

@softage0
Copy link

Any update for this feature?
This might not merge yet.

@KarloX2
Copy link

KarloX2 commented Jan 25, 2018

@Wardrop & @tabalinas : I'm eagerly waiting for this resize feature !=) I there anything missing to get this distributed? I'm looking forward to see this in action. Could you please tell us when to expect this - my project manager keeps asking... THANKS!

@MahdiMahzouni
Copy link

@Wardrop i'd like to contribute by making resizing work on rtl pages too , any suggestions ?
Currently resizing is inverted for rtl direction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants