feat: allow _destroy as a property

The `_destroy: true` property is used as a special key in monolith/ruby-on-rails APIs to indicate that the sub-record should be destroyed so we should allow this specific exception.
tablecheck · Apr 1, 2024 · 55b389a · 55b389a
1 parent 1abc1a6
commit 55b389a
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 0 deletions.
diff --git a/.prettierignore b/.prettierignore
@@ -11,3 +11,4 @@ dist
 .prettierignore
 styleguide
 CHANGELOG.md
+.all-contributorsrc
diff --git a/packages/eslint-config/src/rules/namingConvention.ts b/packages/eslint-config/src/rules/namingConvention.ts
@@ -111,6 +111,15 @@ export const namingRules: Linter.RulesRecord = {
         match: false,
       },
     },
+    {
+      selector: ['property', 'parameterProperty'],
+      format: null,
+      types: ['boolean'],
+      filter: {
+        regex: '^_destroy(_|$)', // `_destroy` and `_destroy_*` is used in monolith APIs as a convention
+        match: true,
+      },
+    },
     {
       selector: ['property', 'parameterProperty'],
       format: ['camelCase', 'PascalCase', 'snake_case', 'UPPER_CASE'],

diff --git a/packages/eslint-config/tests/namingConvention.ts/variables.tsx b/packages/eslint-config/tests/namingConvention.ts/variables.tsx
@@ -11,3 +11,12 @@ function SomeComponent({ icon: Icon, command }) {
   const { other: Other } = command;
   const iconComponentRef = null;
 }
+
+/** _destroy: true special property */
+saveValue({ id: 'id', _destroy: true });
+cy.wait('@monolithSettings_PUT_/sections/1')
+  .its('request.body')
+  .should('deep.equal', {
+    name: 'section 1',
+    _destroy_background_image: true,
+  });