Upgrade to support new Typescript, vite, Vitest and NX tooling

.all-contributorsrc

@@ -1,5 +1,5 @@
 {
-  "projectName": "@tablecheck/tablecheck-react-system",
+  "projectName": "@tablecheck/frontend",
   "projectOwner": "tablecheck",
   "repoType": "github",
   "repoHost": "https://github.com",

.eslintrc.js

@@ -1,40 +1,34 @@
-// this project is NOT typescript compatible - make sure this matches the eslint-config setup
-// basically nothing this requires actually has types or they make no sense
-// this is the only project that should not be in typescript.
+/**
+ * @type {import('eslint').Linter.Config}
+ */
 module.exports = {
-  extends: [
-    'airbnb',
-    'plugin:eslint-comments/recommended',
-    'plugin:jest/recommended',
-    'prettier'
-  ],
-  plugins: ['eslint-comments', 'jest', 'promise'],
+  extends: ['./packages/eslint-config'],
   env: {
     node: true,
-    jest: true
   },
-
-  settings: {
-    jest: {
-      version: 26
-    }
+  parserOptions: {
+    project: './tsconfig.base.json',
   },
   overrides: [
-    require('@tablecheck/eslint-config/overrides/tests'),
     {
       files: ['./packages/codemods/scripts/*.js'],
       rules: {
         'no-case-declarations': 'off',
-        'default-case': 'off'
-      }
-    }
+        'default-case': 'off',
+      },
+    },
+    {
+      files: '*.json',
+      parser: 'jsonc-eslint-parser',
+      rules: {},
+    },
   ],
   rules: {
     'import/no-extraneous-dependencies': [
       'error',
       {
-        devDependencies: true
-      }
+        devDependencies: true,
+      },
     ],
     'import/no-dynamic-require': 'off',
     'global-require': 'off',
@@ -45,7 +39,5 @@ module.exports = {
     'promise/always-return': 'off',
     'promise/avoid-new': 'off',
     'no-underscore-dangle': 'off',
-    // use immer.produce for safety
-    'no-param-reassign': 'off'
-  }
+  },
 };

.github/setup/action.yml

@@ -0,0 +1,40 @@
+name: Setup git and nx
+description: Set up git and nx for the job
+
+runs:
+  using: 'composite'
+  steps:
+    - name: Prepare repository
+      shell: bash
+      run: git fetch --unshallow --prune --tags
+
+    - name: Set shas
+      uses: nrwl/nx-set-shas@v3
+
+    - name: Unset header
+      shell: bash
+      # checkout@v2 adds a header that makes branch protection report errors ):
+      run: git config --local --unset http.https://github.com/.extraheader
+
+    - name: Read .nvmrc
+      shell: bash
+      id: nvm
+      run: echo "::set-output name=nvmrc::$(cat .nvmrc)"
+
+    - name: Setup Node.js
+      uses: actions/setup-node@v2
+      with:
+        node-version: ${{ steps.nvm.outputs.nvmrc }}
+        cache: npm
+
+    - name: Setup branch for NX
+      shell: bash
+      run: git branch --track main origin/main
+
+    - name: Install without scripts 🔧
+      shell: bash
+      run: npm ci --prefer-offline --silent --ignore-scripts
+
+    - name: Build 🔨
+      shell: bash
+      run: npm run build

.github/workflows/docs.yml

@@ -24,7 +24,8 @@ jobs:
 
       - name: Install and Build 🔧
         run: |
-          npm ci
+          git branch --track main origin/main
+          npm ci --prefer-offline --silent
           npm run build
 
       - name: Deploy 🚀

.github/workflows/pull_requests.yml

@@ -12,62 +12,27 @@ concurrency:
 jobs:
   setup:
     runs-on: ubuntu-latest
-    outputs:
-      nvmrc: ${{ steps.nvm.outputs.nvmrc }}
     steps:
       - name: Checkout 🛎️
         uses: actions/checkout@v2
 
-      - name: Read .nvmrc
-        id: nvm
-        run: echo ::set-output name=nvmrc::$(cat .nvmrc)
+      - uses: ./.github/setup
 
-      - name: Setup Node.js
-        uses: actions/setup-node@v2
-        with:
-          node-version: ${{ steps.nvm.outputs.nvmrc }}
-
-      - name: Install 🔧
-        run: npm ci
-
-  lint:
+  checks:
     needs: [setup]
     runs-on: ubuntu-latest
     steps:
       - name: Checkout 🛎️
         uses: actions/checkout@v2
-        with:
-          fetch-depth: 0
-
-      - name: Setup Node.js
-        uses: actions/setup-node@v2
-        with:
-          node-version: ${{ needs.setup.outputs.nvmrc }}
 
-      - name: Restore npm installs and Lerna setup
-        run: npm ci
+      - uses: ./.github/setup
 
       - name: Validate all commits from PR
         run: npx commitlint --from ${{ github.event.pull_request.base.sha }} --to ${{ github.event.pull_request.head.sha }} --verbose
 
       - name: Run linter
         run: npm run lint
 
-  audit:
-    needs: [setup]
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout 🛎️
-        uses: actions/checkout@v2
-
-      - name: Setup Node.js
-        uses: actions/setup-node@v2
-        with:
-          node-version: ${{ needs.setup.outputs.nvmrc }}
-
-      - name: Restore npm installs and Lerna setup
-        run: npm ci
-
       - name: Audit Dependencies
         run: npm run audit:ci
         env:
@@ -81,13 +46,7 @@ jobs:
       - name: Checkout 🛎️
         uses: actions/checkout@v2
 
-      - name: Setup Node.js
-        uses: actions/setup-node@v2
-        with:
-          node-version: ${{ needs.setup.outputs.nvmrc }}
-
-      - name: Restore npm installs and Lerna setup
-        run: npm ci
+      - uses: ./.github/setup
 
       - name: Run Tests
         run: npm test
@@ -100,25 +59,13 @@ jobs:
 
   release:
     runs-on: ubuntu-latest
-    needs: [test, audit, lint]
+    needs: [test, checks]
+    if: github.head_ref != 'next'
     steps:
       - name: Checkout 🛎️
         uses: actions/checkout@v2
-        with:
-          fetch-depth: 0
-          ref: ${{ github.event.pull_request.head.ref }}
-
-      - name: Read .nvmrc
-        id: nvm
-        run: echo ::set-output name=nvmrc::$(cat .nvmrc)
-
-      - name: Setup Node.js
-        uses: actions/setup-node@v2
-        with:
-          node-version: ${{ steps.nvm.outputs.nvmrc }}
 
-      - name: Install 🔧
-        run: npm ci
+      - uses: ./.github/setup
 
       - name: Create Canary Release ✨
         env:

.github/workflows/release.yml

@@ -4,6 +4,7 @@ on:
   push:
     branches:
       - main
+      - next
 
 jobs:
   release:
@@ -13,25 +14,10 @@ jobs:
       - name: Checkout 🛎️
         uses: actions/checkout@v2
 
-      - name: Prepare repository
-        run: git fetch --unshallow --prune --tags
+      - uses: ./.github/setup
 
-      - name: Unset header
-        # checkout@v2 adds a header that makes branch protection report errors ):
-        run: git config --local --unset http.https://github.com/.extraheader
-
-      - name: Read .nvmrc
-        id: nvm
-        run: echo ::set-output name=nvmrc::$(cat .nvmrc)
-
-      - name: Setup Node.js
-        uses: actions/setup-node@v2
-        with:
-          node-version: ${{ steps.nvm.outputs.nvmrc }}
-          cache: npm
-
-      - name: Install 🔧
-        run: npm ci
+      - name: Build
+        run: npm run build
 
       - name: Run Tests
         run: npm test

.gitignore

@@ -11,10 +11,9 @@ cache
 public/static
 docs
 lib
+dist
 config/local.*
 config/local-*
-tsconfig.json
-tsconfig.*.json
 *.tsbuildinfo
 storybook-static
 junit
@@ -23,3 +22,8 @@ junit
 .env.test.local
 .env.production.local
 .@tablecheck
+tsconfig.compound.json
+/packages/quality/build.config.ts
+/packages/utils/build.config.ts
+/tsconfig.eslint.json
+/packages/utils/config

.husky/pre-commit

@@ -1,4 +1,12 @@
 #!/bin/sh
 . "$(dirname "$0")/_/husky.sh"
 
-npm run precommit
+# revert this back to using nx format:check when https://github.com/nrwl/nx/issues/17990 is fixed
+# echo "Running nx format:check - any files output below are formatted incorrectly"
+# echo "To fix formatting, run: \`npx nx format:write\` or configure prettier in your IDE"
+# npx nx format:check
+
+echo "Running 'prettier --check .' - any files output below are formatted incorrectly"
+echo "To fix formatting, run: \`npx prettier --write .\` or configure prettier in your IDE"
+npx prettier -v
+npx prettier --check .

.npmrc

@@ -1 +1,2 @@
-legacy-peer-deps=true
+legacy-peer-deps=true
+save-exact=true

.nvmrc

@@ -1 +1 @@
-v16.15.0
+v18.16.0

.prettierignore

@@ -1,9 +1,10 @@
 package-lock.json
+.npm-upgrade.json
 .eslintignore
 lerna-debug.log
 coverage
 build
-lib
+dist
 .DS_Store
 .gitignore
 .nvmrc

.prettierrc.json

@@ -1,5 +1 @@
-{
-  "singleQuote": true,
-  "arrowParens": "always",
-  "trailingComma": "none"
-}
+"@tablecheck/prettier-config"