fix: shortest-import rule failed with .env file #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimeonC
commented
Oct 10, 2023
SimeonC
force-pushed
the
fix-eslint-plugin-rule
branch
from
e3b2610 to
55ccfdc
Compare
daniellizik
previously approved these changes
Oct 10, 2023
Last version release failed to update the package.json files
SimeonC
force-pushed
the
fix-eslint-plugin-rule
branch
from
5699800 to
037d360
Compare
daniellizik
approved these changes
Oct 10, 2023
SashaShostyr
approved these changes
Oct 10, 2023
tablecheck-public-automation
added
the
released
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue was caused by a
.envfile at the tsconfig root which resolved to a{ '': '...' }in the alias mappings which matched everything.Had troubling navigating around so cleaned up the code as well, this mainly affected
import ... from 'axios'or similar npm level imports.📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: