Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add react-refresh eslint rules #91

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

SimeonC
Copy link
Contributor

@SimeonC SimeonC commented Oct 16, 2023

As we use Vite by default, this eslint rule will help with development and also keeping files consistent. The options to avoid this rule erroring are;

  • Put all styled components/types/utils etc in the same file
  • Put them in other .style.ts or .types.ts or basically a different file.

Trying this at a really strict level to start out and will downgrade to warn if it reports too many false positives.

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/[email protected]
# or 
yarn add @tablecheck/[email protected]

As we use Vite by default, this eslint rule will help with development and also keeping files consistent. The options to avoid this rule erroring are;
* Put all styled components/types/utils etc in the same file
* Put them in other `.style.ts` or `.types.ts` or basically a different file.

Trying this at a really strict level to start out and will downgrade to warn if it reports too many false positives.
@SimeonC SimeonC added the minor Increment the minor version when merged label Oct 16, 2023
@github-actions
Copy link

Unit Test Results

  1 files    3 suites   11s ⏱️
73 tests 73 ✔️ 0 💤 0
75 runs  75 ✔️ 0 💤 0

Results for commit b471892.

@SimeonC SimeonC merged commit 54264e4 into main Oct 17, 2023
5 of 6 checks passed
@SimeonC SimeonC deleted the feat-add-new-eslint-react-refresh-rule branch October 17, 2023 00:27
@tablecheck-public-automation

🚀 PR was released in @tablecheck/[email protected] 🚀

@tablecheck-public-automation tablecheck-public-automation added the released This issue/pull request has been released. label Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants