fix: eslint rules around imports #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimeonC
force-pushed
the
fix-shortest-import-and-eslint-import-naming
branch
from
55207ef to
c106c1c
Compare
SimeonC
commented
Oct 25, 2023
SimeonC
force-pushed
the
fix-shortest-import-and-eslint-import-naming
branch
3 times, most recently
from
2fed5cc to
07a1450
Compare
SimeonC
force-pushed
the
fix-shortest-import-and-eslint-import-naming
branch
3 times, most recently
from
2f3e32a to
0aad08f
Compare
SashaShostyr
previously approved these changes
Oct 25, 2023
SimeonC
force-pushed
the
fix-shortest-import-and-eslint-import-naming
branch
from
0aad08f to
aff75ad
Compare
* Fixed more edge cases for shortestImport. * Added naming convention for imports * made lint executor set type aware options manually
SimeonC
force-pushed
the
fix-shortest-import-and-eslint-import-naming
branch
from
aff75ad to
d8ffe0b
Compare
nkgardose
approved these changes
Oct 26, 2023
SashaShostyr
approved these changes
Oct 26, 2023
|
🚀 PR was released in |
tablecheck-public-automation
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This took me over a day to figure out everything and my eyes are glazing over 😅 .
if you see somewhere I missed a refactor opportunity please let me know 🙇
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: