feat: add a wrapper around @nx/js generator and fix some eslint issues #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimeonC
force-pushed
the
new-nx-plugin
branch
5 times, most recently
from
4ce04a3 to
0f99500
Compare
Wrapping some other libraries so we can easily create new vite libraries in one command.
SimeonC
force-pushed
the
new-nx-plugin
branch
from
0f99500 to
11ea9ba
Compare
Allows us to use the eslint configs more flexibly. Upgrades the quality generator to allow selecting which preset - required for NX cypress project usage.
SimeonC
force-pushed
the
new-nx-plugin
branch
from
33651ec to
912df07
Compare
Resolves the following scenario; * `../Common/ShopSelect` * `~/Common/ShopSelect` These are considered “same length” but we want to prefer the `~` alias path as it’s easier to read than the relative path. Found and fixed another preferred alias’ bug.
SimeonC
changed the title
SimeonC
force-pushed
the
new-nx-plugin
branch
3 times, most recently
from
eec7341 to
b8e6e74
Compare
There is a technically “breaking change” in here, but I know no-one is using the undocumented preferredAlias options yet.
SimeonC
force-pushed
the
new-nx-plugin
branch
from
b8e6e74 to
ac4fb82
Compare
wahidfarid
approved these changes
Nov 2, 2023
nkgardose
approved these changes
Nov 2, 2023
|
🚀 PR was released in |
1 similar comment
|
🚀 PR was released in |
tablecheck-public-automation
added
the
released
|
🚀 PR was released in |
2 similar comments
|
🚀 PR was released in |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wrapping some other libraries so we can easily create new vite libraries in one command.
Also updating Eslint config formats and quality to help with that.
📦 Published PR as canary version:
Canary Versions✨ Test out this PR locally via: