Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx): generators correctly respect “dry-run” #99

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

SimeonC
Copy link
Contributor

@SimeonC SimeonC commented Dec 14, 2023

Without this change we would write the files even in dry-mode. This meant that the “preview” of the generate UI would change files!!

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/[email protected]
# or 
yarn add @tablecheck/[email protected]

Without this change we would write the files even in dry-mode. This meant that the “preview” of the generate UI would change files!!
@SimeonC SimeonC added the patch Increment the patch version when merged label Dec 14, 2023
Copy link

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
0 files    0

Results for commit ba0dd69.

@SimeonC SimeonC requested a review from donaldIvanTC December 15, 2023 01:38
@SimeonC SimeonC merged commit 115e91e into main Dec 15, 2023
5 of 6 checks passed
@SimeonC SimeonC deleted the fix-carbon-icons-generator branch December 15, 2023 01:48
@tablecheck-public-automation

🚀 PR was released in @tablecheck/[email protected] 🚀

@tablecheck-public-automation tablecheck-public-automation added the released This issue/pull request has been released. label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants