-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify license and add note about future migration to MIT #6
base: master
Are you sure you want to change the base?
Conversation
…t be made under the MIT license
LICENSE
Outdated
(see: LICENSE-MIT) in the future. Effective November 8, 2023, by | ||
contributing to this repository, you consent to license under the MIT License | ||
your contribution together with any other contributions to this repository, | ||
its forks, and other repositories in the "prawnpdf" GitHub organization, | ||
in addition to the existing license(s). This includes without limitation: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean that contributions done, for example, only to prawnpdf/prawn should fall under the MIT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I've dialed back the language for now so it covers just this repo. Basically, I'd like to ensure previous Prawn contributors have opted-in to MIT.
I think what I will do instead is make a checkbox in the Issue/PR template something like [ ] I agree for my Prawn contributions (including any other contributions) to be licensed under the MIT License.
Thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you would need to differentiate between code for this repo and all other code written by the person which might include code for Prawn.
So maybe something like [ ] My contribution is licensed under the MIT license.
(just for this repo) and [ ] I agree to license all my contributions that are/will be included in this repo under the MIT license.
(for all code from that one person).
Edit: I think you may have part one already covered via the license file and the statement there. However, the second part makes more sense when the first is also there so that the difference between the two is clearly shown.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep that's exactly what I was thinking.
Clarify license terms
Add provision that future contributions must be made under the MIT license