Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify license and add note about future migration to MIT #6

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

johnnyshields
Copy link

Clarify license terms
Add provision that future contributions must be made under the MIT license

LICENSE Outdated
Comment on lines 9 to 13
(see: LICENSE-MIT) in the future. Effective November 8, 2023, by
contributing to this repository, you consent to license under the MIT License
your contribution together with any other contributions to this repository,
its forks, and other repositories in the "prawnpdf" GitHub organization,
in addition to the existing license(s). This includes without limitation:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mean that contributions done, for example, only to prawnpdf/prawn should fall under the MIT?

Copy link
Author

@johnnyshields johnnyshields Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I've dialed back the language for now so it covers just this repo. Basically, I'd like to ensure previous Prawn contributors have opted-in to MIT.

I think what I will do instead is make a checkbox in the Issue/PR template something like [ ] I agree for my Prawn contributions (including any other contributions) to be licensed under the MIT License.

Thoughts?

Copy link

@gettalong gettalong Nov 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you would need to differentiate between code for this repo and all other code written by the person which might include code for Prawn.

So maybe something like [ ] My contribution is licensed under the MIT license. (just for this repo) and [ ] I agree to license all my contributions that are/will be included in this repo under the MIT license. (for all code from that one person).

Edit: I think you may have part one already covered via the license file and the statement there. However, the second part makes more sense when the first is also there so that the difference between the two is clearly shown.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep that's exactly what I was thinking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants