-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TK V3 #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Restart from scratch for TK v3. Completely different philosophy and architecture.
Adding the start of a script to auto-generate the css values.
Working build - see README.md in system/css for more steps
8d744b7
to
abf5949
Compare
d429825
to
47193bf
Compare
Website should be autodeployed so go forward and fix the bug - don’t try go back…
`baseElement` of `span` or `div` ended up being applied to all elements instead of being restricted to `baseSelector`. This only affected the “Menu” elements.
Adding some language logic and started removing our private CDN references as this is a public project. Fixing more build issues along the way. Refactored the react-select hook out to it’s own package.
Needed to downgrade node to v16 due to https://stackoverflow.com/questions/69692842/error-message-error0308010cdigital-envelope-routinesunsupported Also due to the setup absolute paths aren’t working so we need to keep all paths relative.
…port Changing the utils to give a more consistent DX on both react and css - this also simplifies the css build. Updating the skeleton from a tweet I found to give a super better UX.
Get the CI running again.
# Conflicts: # .github/workflows/pull_requests.yml # packages/icon/package.json
If link doesn’t have a href (ie `:link` doesn’t match) we need to make sure it’s disabled display even when hovered.
Globally applying styles to the a tag caused a large amount of regression problems and couldn’t be modified to work easier than we could create a new component for it. Called `Anchor` as `Link` is commonly used by other apis.
No ticket
Adds `system` alongside `light` and `dark` and defaults to `system` if parameter not passed.
No ticket.
To prevent accidental submission of forms.
Other misc tweaks to match with figma designs. Added support for upcoming `field-sizing` property that design team wants by default
Apply correct text color for input and select when element is disabled.
Final update to prepare for full release. Merge next -> main after this.
anarakhlina
approved these changes
May 27, 2024
k-baldauf
approved these changes
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in draft until ready to release, it's a PR so we can trigger pre-release builds and generally keep track of progress.
The CSS is via jsDelivr like bootstrap see these links (latest version will be wrong until first full release, make sure to include the latest canary version from below);
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via:
Version
Published prerelease version:
@tablecheck/[email protected]
@tablecheck/[email protected]
@tablecheck/[email protected]
@tablecheck/[email protected]
@tablecheck/[email protected]
@tablecheck/[email protected]
@tablecheck/[email protected]
Changelog
🎉 This release contains work from new contributors! 🎉
Thanks for all your work!
❤️ Alex (@SashaShostyr)
❤️ null@k-baldauf
❤️ Neilson Gardose (@nkgardose)
❤️ null@Maruth51
❤️ Hachi (@hachi-studio)
❤️ Stanislav (@staevs)
❤️ Frederic Wojcikowski (@Fred6475)
❤️ null@oFrederic
❤️ Joan Mira (@gazpachu)
💥 Breaking Change
@tablecheck/tablekit-core
,@tablecheck/tablekit-css
,@tablecheck/tablekit-react-css
,@tablecheck/tablekit-react-datepicker
,@tablecheck/tablekit-react-fit-content-textarea
,@tablecheck/tablekit-react-select
,@tablecheck/tablekit-react
@tablecheck/tablekit-react-datepicker
,@tablecheck/tablekit-react-select
,@tablecheck/tablekit-react
🚀 Enhancement
@tablecheck/tablekit-core
,@tablecheck/tablekit-react-css
,@tablecheck/tablekit-react
themedCss
util #211 (@SimeonC)@tablecheck/tablekit-core
data-variant
as prop forMenuItem
#196 (@nkgardose)@tablecheck/tablekit-css
,@tablecheck/tablekit-react-datepicker
,@tablecheck/tablekit-react-fit-content-textarea
,@tablecheck/tablekit-react-select
,@tablecheck/tablekit-react
@tablecheck/tablekit-react
@tablecheck/tablekit-react-fit-content-textarea
,@tablecheck/tablekit-react
@tablecheck/tablekit-css
,@tablecheck/tablekit-react-fit-content-textarea
,@tablecheck/tablekit-react-select
,@tablecheck/tablekit-react
@tablecheck/tablekit-react-select
🐛 Bug Fix
@tablecheck/tablekit-core
,@tablecheck/tablekit-react-select
@tablecheck/tablekit-core
,@tablecheck/tablekit-react
@tablecheck/tablekit-core
InputAlert
#187 (@nkgardose)@tablecheck/tablekit-react-datepicker
@tablecheck/tablekit-react-select
@tablecheck/tablekit-core
,@tablecheck/tablekit-react-css
,@tablecheck/tablekit-react
@tablecheck/tablekit-css
@tablecheck/tablekit-react
@tablecheck/tablekit-css
,@tablecheck/tablekit-react-select
,@tablecheck/tablekit-react
next
@tablecheck/tablekit-css
,@tablecheck/tablekit-react
@tablecheck/tablekit-react
@tablecheck/tablekit-css
,@tablecheck/tablekit-react-select
,@tablecheck/tablekit-react
@tablecheck/tablekit-css
📝 Documentation
@tablecheck/tablekit-core
,@tablecheck/tablekit-react
InputAlert
#186 (@nkgardose)🔩 Dependency Updates
Authors: 12