Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tablekit-core): update padding to new styling and fix other visu… #216

Merged
merged 1 commit into from
Feb 14, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions auditjs.json
Original file line number Diff line number Diff line change
Expand Up @@ -1148,6 +1148,54 @@
"reference": "https://ossindex.sonatype.org/vulnerability/CVE-2023-46234?component-type=npm&component-name=browserify-sign&utm_source=auditjs&utm_medium=integration&utm_content=4.0.39"
}
]
},
{
"coordinates": "pkg:npm/[email protected]",
"description": "HTTP and HTTPS modules that follow redirects.",
"reference": "https://ossindex.sonatype.org/component/pkg:npm/[email protected]?utm_source=auditjs&utm_medium=integration&utm_content=4.0.39",
"vulnerabilities": [
{
"id": "CVE-2023-26159",
"title": "[CVE-2023-26159] CWE-20: Improper Input Validation",
"description": "Versions of the package follow-redirects before 1.15.4 are vulnerable to Improper Input Validation due to the improper handling of URLs by the url.parse() function. When new URL() throws an error, it can be manipulated to misinterpret the hostname. An attacker could exploit this weakness to redirect traffic to a malicious site, potentially leading to information disclosure, phishing attacks, or other security breaches.",
"cvssScore": 6.1,
"cvssVector": "CVSS:3.1/AV:N/AC:L/PR:N/UI:R/S:C/C:L/I:L/A:N",
"cve": "CVE-2023-26159",
"reference": "https://ossindex.sonatype.org/vulnerability/CVE-2023-26159?component-type=npm&component-name=follow-redirects&utm_source=auditjs&utm_medium=integration&utm_content=4.0.39"
}
]
},
{
"coordinates": "pkg:npm/[email protected]",
"description": "[![](https://badge.fury.io/js/ip.svg)](https://www.npmjs.com/package/ip)",
"reference": "https://ossindex.sonatype.org/component/pkg:npm/[email protected]?utm_source=auditjs&utm_medium=integration&utm_content=4.0.39",
"vulnerabilities": [
{
"id": "CVE-2023-42282",
"title": "[CVE-2023-42282] CWE-918: Server-Side Request Forgery (SSRF)",
"description": "An issue in NPM IP Package v.1.1.8 and before allows an attacker to execute arbitrary code and obtain sensitive information via the isPublic() function.",
"cvssScore": 7.2,
"cvssVector": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:C/C:L/I:L/A:N",
"cve": "CVE-2023-42282",
"reference": "https://ossindex.sonatype.org/vulnerability/CVE-2023-42282?component-type=npm&component-name=ip&utm_source=auditjs&utm_medium=integration&utm_content=4.0.39"
}
]
},
{
"coordinates": "pkg:npm/[email protected]",
"description": "[![](https://badge.fury.io/js/ip.svg)](https://www.npmjs.com/package/ip)",
"reference": "https://ossindex.sonatype.org/component/pkg:npm/[email protected]?utm_source=auditjs&utm_medium=integration&utm_content=4.0.39",
"vulnerabilities": [
{
"id": "CVE-2023-42282",
"title": "[CVE-2023-42282] CWE-918: Server-Side Request Forgery (SSRF)",
"description": "An issue in NPM IP Package v.1.1.8 and before allows an attacker to execute arbitrary code and obtain sensitive information via the isPublic() function.",
"cvssScore": 7.2,
"cvssVector": "CVSS:3.1/AV:N/AC:L/PR:N/UI:N/S:C/C:L/I:L/A:N",
"cve": "CVE-2023-42282",
"reference": "https://ossindex.sonatype.org/vulnerability/CVE-2023-42282?component-type=npm&component-name=ip&utm_source=auditjs&utm_medium=integration&utm_content=4.0.39"
}
]
}
],
"ignore": [
Expand Down Expand Up @@ -1369,6 +1417,12 @@
},
{
"id": "CVE-2023-46234"
},
{
"id": "CVE-2023-26159"
},
{
"id": "CVE-2023-42282"
}
]
}
14 changes: 7 additions & 7 deletions system/core/src/components/Table.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ export const className = 'table';
export interface Props {}

export const baseStyles = css`
text-align: left;
text-align: start;
border-spacing: 0;
border-collapse: separate;
border: 1px solid var(--border);
Expand All @@ -34,14 +34,18 @@ export const baseStyles = css`

& th,
& td {
vertical-align: middle;
vertical-align: baseline;
white-space: nowrap;
overflow: hidden;
padding: 18px var(--spacing-l5);
padding: var(--spacing-l4);
}

& th {
border-bottom: 1px solid var(--border);
text-align: left;
[dir='rtl'] & {
text-align: right;
}

& > .table-resizer {
display: inline-block;
Expand All @@ -68,8 +72,4 @@ export const baseStyles = css`
& tfoot:not(:last-child) {
border-bottom: 1px solid var(--border);
}

&[aria-hidden='true'] {
display: none;
}
`;
Loading