-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disabled styles for Checkbox and Radio labels #222
Conversation
✅ Deploy Preview for tablekit ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
9a9081d
to
ac3aee4
Compare
ac3aee4
to
e427423
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This kind of change allows for incorrect semantics so we don't want to do that. Disabled styles on an input should only be applied when the pseudo element or prop is there.
e427423
to
e91a8c0
Compare
Removed |
e91a8c0
to
5f55483
Compare
I'll close this as this is included in #223 with the tests and everything to check it's working. |
Issue example:
📦 Published PR as canary version:
Canary Versions
✨ Test out this PR locally via: