Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: disabled styles for Checkbox and Radio labels #222

Closed
wants to merge 1 commit into from

Conversation

SashaShostyr
Copy link
Contributor

@SashaShostyr SashaShostyr commented Apr 25, 2024

Issue example:
image

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.222.9078713800.0
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
# or 
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/tablekit-react-fit-content-textarea@2.0.1-canary.222.9078713800.0
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]

@SashaShostyr SashaShostyr requested a review from SimeonC April 25, 2024 11:25
Copy link

netlify bot commented Apr 25, 2024

Deploy Preview for tablekit ready!

Name Link
🔨 Latest commit 5f55483
🔍 Latest deploy log https://app.netlify.com/sites/tablekit/deploys/66434dc4715add0008e6eb50
😎 Deploy Preview https://deploy-preview-222--tablekit.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

github-actions bot commented Apr 25, 2024

Unit Test Results

0 tests  ±0   0 ✔️ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
1 files   ±0   0 ±0 

Results for commit 5f55483. ± Comparison against base commit e6cf4f8.

♻️ This comment has been updated with latest results.

@SashaShostyr SashaShostyr force-pushed the fix-disabled-styles-checkbox-radio-label branch from 9a9081d to ac3aee4 Compare April 25, 2024 11:30
@SashaShostyr SashaShostyr added the patch Increment the patch version when merged label Apr 25, 2024
@SashaShostyr SashaShostyr force-pushed the fix-disabled-styles-checkbox-radio-label branch from ac3aee4 to e427423 Compare April 25, 2024 14:17
Copy link
Contributor

@SimeonC SimeonC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This kind of change allows for incorrect semantics so we don't want to do that. Disabled styles on an input should only be applied when the pseudo element or prop is there.

@SashaShostyr SashaShostyr force-pushed the fix-disabled-styles-checkbox-radio-label branch from e427423 to e91a8c0 Compare May 2, 2024 14:38
@SashaShostyr
Copy link
Contributor Author

This kind of change allows for incorrect semantics so we don't want to do that. Disabled styles on an input should only be applied when the pseudo element or prop is there.

Removed

@SashaShostyr SashaShostyr requested a review from SimeonC May 2, 2024 14:39
@SashaShostyr SashaShostyr force-pushed the fix-disabled-styles-checkbox-radio-label branch from e91a8c0 to 5f55483 Compare May 14, 2024 11:40
@SashaShostyr SashaShostyr requested a review from SimeonC May 14, 2024 11:41
@SimeonC
Copy link
Contributor

SimeonC commented May 16, 2024

I'll close this as this is included in #223 with the tests and everything to check it's working.

@SimeonC SimeonC closed this May 16, 2024
@SashaShostyr SashaShostyr deleted the fix-disabled-styles-checkbox-radio-label branch October 11, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants