Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the Badge component should be default act like an “inline” component #236

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

SimeonC
Copy link
Contributor

@SimeonC SimeonC commented Jun 28, 2024

Fixing some typescript misses and adding utility table components to make it easier to remember how to correctly style around badge/button components in a table

📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
# or 
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]

@SimeonC SimeonC added the patch Increment the patch version when merged label Jun 28, 2024
Copy link

github-actions bot commented Jun 28, 2024

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
1 files    0

Results for commit 4461e05.

♻️ This comment has been updated with latest results.

anarakhlina
anarakhlina previously approved these changes Jun 28, 2024
@SimeonC SimeonC enabled auto-merge (rebase) June 28, 2024 10:24
hrlclem
hrlclem previously approved these changes Jun 28, 2024
@SimeonC SimeonC force-pushed the fix-badge-display branch from c35124d to fb85b15 Compare July 1, 2024 02:12
@SimeonC SimeonC changed the title fix: the Badge component should be default act like an “inline” compo… fix: the Badge component should be default act like an “inline” component Jul 2, 2024
@SimeonC SimeonC force-pushed the fix-badge-display branch from fb85b15 to 5c4cefe Compare July 2, 2024 02:13
…nent

Fixing some typescript misses and adding utility table components to make it easier to remember how to correctly style around badge/button components in a table
@SimeonC SimeonC force-pushed the fix-badge-display branch from 5c4cefe to 4461e05 Compare July 2, 2024 03:04
@SimeonC SimeonC merged commit c8ce3a2 into main Jul 3, 2024
9 of 10 checks passed
@SimeonC SimeonC deleted the fix-badge-display branch July 3, 2024 00:55
@tablecheck-public-automation tablecheck-public-automation added the released This issue/pull request has been released. label Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants