Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support withComponent on all react-css components #245

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

SimeonC
Copy link
Contributor

@SimeonC SimeonC commented Nov 25, 2024

This adds full compatibility support between the emotion and css versions of tablekit so we can start phasing out the emotion version

Fixed up some missing/incorrect stories as well.
CleanShot 2024-11-25 at 13 12 27

There's some fancy types for supporting withComponent - much better than the tablekit-react "emotion" way. Supports doing this;

const ButtonItem = styled(
  VariantButton.Bare.withComponent('button', {
    'data-size': 'large',
  }),
)`
  justify-content: space-between;
`;
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
# or 
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]

@SimeonC SimeonC added the minor Increment the minor version when merged label Nov 25, 2024
@SimeonC SimeonC force-pushed the support-withComponent-react-css branch 2 times, most recently from 12a8638 to 0809803 Compare November 25, 2024 01:53
Copy link

github-actions bot commented Nov 25, 2024

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
1 files    0

Results for commit 0f9fa62.

♻️ This comment has been updated with latest results.

@SimeonC SimeonC force-pushed the support-withComponent-react-css branch 6 times, most recently from 1951fcc to 297767a Compare November 25, 2024 03:37
@SimeonC SimeonC changed the title feat: support withComponent on all react-css components feat: sentiment borders and support withComponent on all react-css components Nov 25, 2024
@SimeonC SimeonC enabled auto-merge (rebase) November 25, 2024 04:16
wahidfarid
wahidfarid previously approved these changes Nov 26, 2024
This adds full compatibility support between the emotion and css versions of tablekit so we can start phasing out the emotion version.
@SimeonC SimeonC changed the title feat: sentiment borders and support withComponent on all react-css components feat: support withComponent on all react-css components Nov 26, 2024
@SimeonC SimeonC merged commit cf6aa43 into main Nov 26, 2024
10 checks passed
@SimeonC SimeonC deleted the support-withComponent-react-css branch November 26, 2024 06:34
@SimeonC SimeonC added the released This issue/pull request has been released. label Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor Increment the minor version when merged released This issue/pull request has been released.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants