Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly scope checkboxes and radios in classy to avoid conflicts #246

Merged
merged 1 commit into from
Dec 2, 2024
Merged

fix: correctly scope checkboxes and radios in classy to avoid conflicts #246

merged 1 commit into from
Dec 2, 2024
+136 −99

Conversation

SimeonC
Copy link
Contributor

@SimeonC SimeonC commented Nov 27, 2024 •
edited by github-actions bot
Loading

Removed width calculation on InputWithIcons/Prefix as calc(var(…)+ 2) is ignored due to var(…)+ being invalid. A space is required between ) and +

image

Fixing this conflict with toggle elements

  • react -> react-css upgrade compatibility
  • not needing .custom to override the styles in classy mode
📦 Published PR as canary version: Canary Versions

✨ Test out this PR locally via:

npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
npm install @tablecheck/[email protected]
# or 
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]
yarn add @tablecheck/[email protected]

@SimeonC SimeonC added the patch Increment the patch version when merged label Nov 27, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 27, 2024 •
edited
Loading

Unit Test Results

0 tests   0 ✔️  0s ⏱️
0 suites  0 💤
1 files    0 ❌

Results for commit 38e9303.

♻️ This comment has been updated with latest results.

@SimeonC SimeonC force-pushed the fix-css-checkbox-radio branch 3 times, most recently from 942ee3f to 1b1a328 Compare November 27, 2024 05:06
wahidfarid
wahidfarid previously approved these changes Nov 27, 2024
View reviewed changes
@SimeonC SimeonC force-pushed the fix-css-checkbox-radio branch 2 times, most recently from 6577b10 to 543ebbe Compare November 28, 2024 00:11
@SimeonC
fix: correctly scope checkboxes and radios in classy to avoid conflicts
38e9303 
Removed `width` calculation that was ignored as `calc(var(…)+ 2)` is ignored due to `var(…)+` being invalid. A space is required between `)` and `+`
@SimeonC SimeonC force-pushed the fix-css-checkbox-radio branch from 543ebbe to 38e9303 Compare November 28, 2024 06:17
@SimeonC SimeonC requested a review from wahidfarid November 28, 2024 09:00
@SimeonC SimeonC enabled auto-merge (rebase) December 2, 2024 02:35
@SimeonC SimeonC merged commit e0f43e8 into main Dec 2, 2024
10 checks passed
@SimeonC SimeonC deleted the fix-css-checkbox-radio branch December 2, 2024 02:53
@SimeonC
Copy link
Contributor Author

SimeonC commented Dec 2, 2024

🚀 PR was released in @tablecheck/[email protected], @tablecheck/[email protected], @tablecheck/[email protected], @tablecheck/[email protected], @tablecheck/[email protected], @tablecheck/[email protected] 🚀

@SimeonC SimeonC added the released This issue/pull request has been released. label Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wahidfarid wahidfarid wahidfarid approved these changes

@whanchong whanchong whanchong approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SimeonC @whanchong @wahidfarid