Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Horizontal scroll version of the table component #13

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

civan
Copy link
Collaborator

@civan civan commented Aug 29, 2023

  • updated storybook with this new flag hasScrollX when set to true allows the table to scroll
Screen.Recording.2023-08-29.at.12.56.33.PM.mov

@civan civan requested review from alotropico and ciminelli August 29, 2023 18:00
alotropico
alotropico previously approved these changes Aug 30, 2023
# Conflicts:
#	src/Table/style/Default.module.scss
Copy link
Member

@ciminelli ciminelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename VerticalScroll to HorizontalScroll? Or am I mixing the two up here :)

Copy link
Member

@ciminelli ciminelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update TableVScroll? 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants