-
-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate dynamic imports for icons-react #1081
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Will this PR be merged, or should I make some changes? |
I NEED this for my current project. Please merge it whoever needs to :'( |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
Still interested in this feature. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
I would love to have this feature, any chance to integrate this in the next release? |
Is there a chance somebody could merge this? This is valuable and highly desired! |
thank you for your help! ❤️ |
Since this is now crashing people's machines in development mode, can this PR be reversed? It's not fun having people yell at me every day that this package breaks there dev server just because I recommended it as a peerDep. |
Would be a good idea to reverse this, because we have problems too |
fixes #998
This PR generates a dynamic import for every Icon, so it can be used for lazy loading.
Also i had to use
slash
when building, because Windows could not read the joined path.