Skip to content

Commit

Permalink
Update ChangeLog, remove "TODO" mark from tests related to RexOps#1508
Browse files Browse the repository at this point in the history
This is made in a separate commit so to ease cherry-picking
between two alternative fixes proposed in distinct commits.

In any case, all tests pass either way.

CHANGES:
=============
modified: t/issue/1508.t
modified: ChangeLog

HOW TO TEST :
=============
$ prove -v t/issue/1508.t   # for this issue
$ prove t/**/*.t            # for non-regression
  • Loading branch information
tabulon committed Sep 27, 2021
1 parent a011f27 commit 4c33d32
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
1 change: 1 addition & 0 deletions ChangeLog
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ Revision history for Rex

[BUG FIXES]
- Detect invalid hostgroup expressions
- Propagate args/params down to "needed" tasks launched by needs()

[DOCUMENTATION]

Expand Down
4 changes: 2 additions & 2 deletions t/issue/1508.t
Original file line number Diff line number Diff line change
Expand Up @@ -144,9 +144,9 @@ task test6 => sub {
T::check_needed( $_, { argv => \@_ } ) for (qw/test /);
};

TODO: {
local $TODO = "Issue 1508: The needs() function should propogate parameters/args";


{
my $task_list = Rex::TaskList->create;
my $run_list = Rex::RunList->instance;
$run_list->parse_opts(qw/test test2 test3 test5 test6/);
Expand Down

0 comments on commit 4c33d32

Please sign in to comment.