-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(stdlib): Add SendDefaultMode
#1010
Conversation
Closes 988
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also suggest to change the mode: Int = 0;
to use the new constant in stdlib/std/send.tact
Co-authored-by: Novus Nota <[email protected]>
Add the |
You can suggest and commit this change. In my opinion, it clutters the table. |
I have no idea what is wrong w/ `npm fix`
The CI issue is NOT related to package.json. Instead, you just forgot to run |
Also, before we've merged this PR, I'd like to add a small change to it — to exclude the links to web ide from site search as they can really cripple its speed. I'm working on it. UPD: The fix is to add // line 78
'<a data-pagefind-ignore="all"', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @Gusarich about mode: 0
in the SendParameters
structure. And also, we should use mode: SendDefaultMode
in all the examples and tests instead of mode: 0
(but let's not change the implicit modes)
@anton-trunov using it in the structure definition leads to the compilation error. |
@anton-trunov yes |
Closes #988