implemented a rule to forbid the export of symbols #1729
+3,114
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Danil42Russia
changed the title
verytactical
reviewed
Feb 7, 2025
| @@ -0,0 +1,6 @@ | |||
| { | |||
There was a problem hiding this comment.
A scary experiment, but we have #1045 and have to start somewhere...
verytactical
reviewed
Feb 7, 2025
| @@ -0,0 +1,3 @@ | |||
| const exampleSymbol = Symbol("example"); | |||
There was a problem hiding this comment.
The primary reason I postponed doing this is that I remember there was an official template for eslint rule definitions, and I couldn't find it.
It required positive tests, negative tests and documentation, and also rules were implemented in TypeScript.
It's nice to have this error message in CI, but
a) we'll have to remove it
b) I also wonder whether it works with export const, and can't easily see it in tests
Finding/making the rule template is considerably more important :/
There was a problem hiding this comment.
- updated to match the template
- added tests
anton-trunov
requested changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
I'm writing a description. I created an MR to show the error.
<!-
Чтобы понять почему получилось такое решение, давайте я опишу проблемы, которые мне не дали сделать через
TypeScripteslintи старый способ конфигурации, из-за этого нельзя подключать плагины как модулиJavaScript. Из-за этого нужно соблюдать правила именования пакетов.workspaces, но есть проблема. В проекте используетсяyarn1 версии, и чтобы их начать использовать надо сделать проект приватным, но это не даст публиковать данный проект в npm репозиторий. Такжеyarnданный версии не даст подключить проект изworkspacesв главный проект через синтаксworkspace:^workspaces, то можно пользоваться только подключением черезfile:/path/to/folder. Но это не симлинка, а копирование файлов из папки вnode_modulesво время установки пакетовTypeScript-->
Closes #1695.
Checklist