Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docs): exit codes page overhaul #978

Merged
merged 5 commits into from
Oct 24, 2024
Merged

feat(docs): exit codes page overhaul #978

merged 5 commits into from
Oct 24, 2024

Conversation

novusnota
Copy link
Member

@novusnota novusnota commented Oct 22, 2024 •
edited
Loading

Issue

Closes #887.

Checklist

  • I have updated CHANGELOG.md
  • I have run the linter, formatter and spellchecker
  • I did not do unrelated and/or undiscussed refactorings

Preview

image

@novusnota novusnota marked this pull request as ready for review October 24, 2024 11:00
@novusnota novusnota requested a review from a team as a code owner October 24, 2024 11:00
@novusnota novusnota added this to the v1.6.0 milestone Oct 24, 2024
jeshecdom
jeshecdom reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@jeshecdom jeshecdom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, I liked the examples. Just minor comments below.

docs/src/content/docs/book/exit-codes.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/exit-codes.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/exit-codes.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/exit-codes.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/exit-codes.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/exit-codes.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/exit-codes.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/exit-codes.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/exit-codes.mdx Show resolved Hide resolved
docs/src/content/docs/book/exit-codes.mdx Outdated Show resolved Hide resolved
anton-trunov
anton-trunov requested changes Oct 24, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tremendous work! Let's fix some minor things, though

CHANGELOG.md Outdated Show resolved Hide resolved
docs/src/content/docs/book/exit-codes.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/exit-codes.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/exit-codes.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/exit-codes.mdx Outdated Show resolved Hide resolved
docs/src/content/docs/book/exit-codes.mdx Outdated Show resolved Hide resolved
@novusnota
fix: address suggestions from code review
0667ba3 
Major props for reviewing it so quickly!
@novusnota
Copy link
Member Author

novusnota commented Oct 24, 2024 •
edited
Loading

Btw, TON Docs feature 25 exit codes, while this PR states 39 including Tact ones and 29 without them

anton-trunov
anton-trunov approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@anton-trunov anton-trunov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Let's wait until @jeshecdom green-lights it too

@anton-trunov
Copy link
Member

Btw, TON Docs feature 25 exit codes, while this PR states 39 including Tact ones and 29 without them

Could you please open an issue about the non-Tact-specific exit codes that are missing from the TON Docs? (and link it here as well)

@anton-trunov anton-trunov self-assigned this Oct 24, 2024
jeshecdom
jeshecdom reviewed Oct 24, 2024
View reviewed changes
Copy link
Contributor

@jeshecdom jeshecdom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anton-trunov anton-trunov merged commit 458f996 into main Oct 24, 2024
20 checks passed
@anton-trunov anton-trunov deleted the closes-887-exit-codes branch October 24, 2024 18:59
@novusnota novusnota mentioned this pull request Oct 24, 2024
Open
@novusnota
Copy link
Member Author

→ ton-community/ton-docs#805

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeshecdom jeshecdom jeshecdom left review comments

@anton-trunov anton-trunov anton-trunov approved these changes

@Gusarich Gusarich Awaiting requested review from Gusarich

Assignees

@anton-trunov anton-trunov

Labels
None yet
Projects
None yet
Milestone
v1.6.0
Development

Successfully merging this pull request may close these issues.

Re-write exit-codes.mdx into an article of the Book
3 participants
@novusnota @anton-trunov @jeshecdom