-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Serialize/Deserialize slices without length prefix #208
base: master
Are you sure you want to change the base?
Conversation
Hi! The PR looks good; I was actually considering a few options, since this seems to be a common stumbling block for new users:
What do you think? Something to consider is the fact that we might have breaking changes already anyway from other PRs #235 and #240. |
Is there any progress on this pr :-) |
In my opinion, since we already have breaking changes from other PRs that look like they're going to be merged, let's go with option 1 above. That is, just change the functions to no longer include the prefix, and don't include any backwards-compatibility functions that do, because that seems a bit messy to me. Counterarguments are welcome though! I don't know of any particular use for the functions that have length prefixes, so my instinct is to remove them for the sake of keeping the API intuitive and small. Are you okay with this @AlaaZorkane? I understand of course that this PR was awhile ago haha 😅 so I will likely make the change myself in a bit if there's no response. Do let me know if you want to do it yourself though! |
I think can add two methods this pr or next pr
|
Following: #202
This PR adds the following: