Fix issue689

[LoiNguyenCS]

Dear @tahiat,

This PR is not ready for merge. We also need to change the .json file somehow so that the target method signature will be: java.util.SubList#listIterator(int). SubList is a class inside AbstractList.java, but it is not an inner class. I don't know how to change the .json file to reflect that fact.

Thank you for your time.

[kelloggm]

This PR is not ready for merge. We also need to change the .json file somehow so that the target method signature will be: java.util.SubList#listIterator(int). SubList is a class inside AbstractList.java, but it is not an inner class. I don't know how to change the .json file to reflect that fact.

This is a tricky case! The signature should not be java.util.SubList#listIterator(int), because the fully-qualified name of the SubList class inside AbstractList is not java.util.SubList. In fact, that class (and other "local" classes) do not have fully-qualified names (according to the JLS). The class' name is SubList, but it is only accessible (and its methods only callable) from within AbstractList.java.

We probably need an alternative syntax for this case (which will require special support in Specimin). I would suggest something like java.util.AbstractList$SubList#listIterator(int), as if it were an inner class, since the class name needs to be unique in the file (so this won't be ambiguous).

[LoiNguyenCS]

We probably need an alternative syntax for this case (which will require special support in Specimin). I would suggest something like java.util.AbstractList$SubList#listIterator(int), as if it were an inner class, since the class name needs to be unique in the file (so this won't be ambiguous).

I can do this. Thank you very much for your clarification.

[tahiat]

@LoiNguyenCS , If we are using the full qualified name for SubList as java.util.AbstractList$SubLis then I am going the change the target method signature as java.util.AbstractList$SubList#listIterator(int) in the script file.

[LoiNguyenCS]

Professor,

For some reasons JavaParser still returns the fully qualified name for SubList, while their documentation says that they don't return qualified names for local classes. So I have been looking up the documentation of Oracle. They declares a local class as

classes that are defined in a block, which is a group of zero or more statements between balanced braces

Given this declaration, I don't think SubList is a local class. Could you help me double-check? Thank you.

[LoiNguyenCS]

We have merged the PR to solve this issue into Specimin. Basically, the signatures of non-primary classes should be the package names and the names of those classes only. That is to say, the signature of the target method for this issue will be java.util.SubList#listIterator(int).

[tahiat]

Looks good

[LoiNguyenCS]

Hello @tahiat, this PR is not actually correct. The target method signature needs to be java.util.SubList#listIterator(int). Currently, the target method signature is java.util.AbstractList.SubList#listIterator(int).

[tahiat]

@LoiNguyenCS , This PR will fix this. Please review this