Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic benchmarking works now #104

Merged
merged 4 commits into from
Oct 23, 2023
Merged

Basic benchmarking works now #104

merged 4 commits into from
Oct 23, 2023

Conversation

itamarst
Copy link

Fixes #81

$ python bench/bench_zfec.py 
measuring encoding of data with K=3, M=10, encoding 1000000 bytes 1000 times in a row...
Average MB/s: 361.6112747502577

@itamarst
Copy link
Author

Maybe I'll add decoding too to this PR, presumably decoding happens more often than encoding.

@itamarst
Copy link
Author

Decoding is actually very fast!

exarkun
exarkun reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@exarkun exarkun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Just a couple minor comments inline. Please address and merge.

bench/bench_zfec.py Show resolved Hide resolved
bench/bench_zfec.py Show resolved Hide resolved
@itamarst itamarst mentioned this pull request Oct 23, 2023
Closed
@itamarst
Copy link
Author

Addressed, but I can't merge since I don't have write access to this repo.

@exarkun exarkun merged commit f2d7d29 into tahoe-lafs:master Oct 23, 2023
49 of 50 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exarkun exarkun exarkun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Benchmarks do not work with Python 3.x
3 participants
@itamarst @exarkun @pythonspeed