Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported versions: add newer CPython and PyPy, drop 3.7 #112

Merged
merged 8 commits into from
Sep 4, 2024

Conversation

itamarst
Copy link

@itamarst itamarst commented Jun 19, 2024

Fixes #111
Fixes #67

  • Switch to modern Python 3 buffer APIs, since the old style was dropped in Python 3.13
  • Drop Python 3.7 support
  • Add Python 3.13 support
  • Add Python 3.12 testing in place where it was missed
  • Add PyPy 3.10

Note to reviewer: Reviewing the C code and CPython API usage (PyBuffer_Release etc) for correctness is extremely important, so we don't have memory unsafety issues.

- "macos-11"
- "macos-12"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, that's good to know... assuming we can build a wheel that works on older macOS. Which cibuildwheel might automate. Or not.

@itamarst itamarst marked this pull request as ready for review June 20, 2024 18:43
@itamarst itamarst requested a review from sajith June 20, 2024 18:44
Copy link
Collaborator

@meejah meejah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I'm not super-familiar with the new C buffer protocol, but triple-checked the ref-counting and that at least looks good to me.

@meejah meejah merged commit ebc017b into tahoe-lafs:master Sep 4, 2024
55 of 56 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.13 support _fecmodule.c uses some deprecated CPython APIs
4 participants