-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update supported versions: add newer CPython and PyPy, drop 3.7 #112
Conversation
- "macos-11" | ||
- "macos-12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub says that macos-14
will use M1 macs, if that is useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, that's good to know... assuming we can build a wheel that works on older macOS. Which cibuildwheel might automate. Or not.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I'm not super-familiar with the new C buffer protocol, but triple-checked the ref-counting and that at least looks good to me.
Fixes #111
Fixes #67
Note to reviewer: Reviewing the C code and CPython API usage (
PyBuffer_Release
etc) for correctness is extremely important, so we don't have memory unsafety issues.