Cache new asset price points #3408
Conversation
If we are using function that will trigger fetching new prices for assets then these prices should be cached. Lets try dispatching `newPricePoint` on demand with these new prices.
|
To approach the “something” better here, wanted to suggest a quick thought: right now, we generate the buy and sell currency amounts alongside the regular lookup of the quote. Instead of doing that, we could calculate buy and sell currency amounts live in the swap component based on selected data from the redux store. Then, when we generate the quote, we trigger a request to get up-to-date price data to either the indexing service or the asset slice. Then the indexing service/asset slice is in charge of inspecting whether the price data that is currently available is recent enough, and trigger a lookup if not. Once the lookup completes and that data is available, the price info would display (since we'd be using a selector that would trigger immediately). What this doesn't let us do is show a loading spinner while the price data resolves, so there's more to ponder there. |
|
Closing as stale |
Resolves #3406
It's working but very ugly approach right now 🤢 will think about something better
What
If we are using a function that will trigger fetching new prices for assets then these prices should be cached.
Let's try dispatching
newPricePointon demand with these new prices.Latest build: extension-builds-3408 (as of Thu, 25 May 2023 14:28:21 GMT).