Move action using node12 to a newer version #3722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Node12 has been out of support since April 2022. As a result GH has started the deprecation process of Node12 for GitHub Actions by migrating all actions to run on Node16 ([read more](https://github.blog/changelog/2023-07-17-github-actions-removal-of-node12-from-the-actions-runner/)). The `softprops/action-gh-release` action's version which we used in the `build.yml` workflow was running on Node12. But a newer version (`v0.1.15`) of the action is run on Node16. We're swithing to using that newer version. This should make `The following actions uses node12 which is deprecated and will be forced to run on node16: softprops/action-gh-release@1e07f4...` annotation disappear from the details of the workflow runs. The upgrade may also remove the `The "set-output" command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/` annotation.
This bumps underlying Node to 0.20, which is the current LTS release through 2026.
Merged
Shadowfiend
added a commit
that referenced
this pull request
Oct 5, 2024
## What's Changed * v0.57.0 by @Shadowfiend in #3735 * Support for Wallet Test Framework by @SamWilsn in #3737 * Fix typos by @omahs in #3724 * Fix a couple of typos from contribution by @Shadowfiend in #3742 * Move action using node12 to a newer version by @michalinacienciala in #3722 * Changed the build for the firefox browser by @kogeletey in #3733 * Remove Goerli testnet from the testnets list by @michalinacienciala in #3718 * Move autolock timer by @radchukd in #3743 * Tweaks and creaks: Disable UNS, fix Ledger signing on built-in non-ETH/MATIC networks by @Shadowfiend in #3746 ## New Contributors * @SamWilsn made their first contribution in #3737 * @kogeletey made their first contribution in #3733 * @radchukd made their first contribution in #3743 Latest build: [extension-builds-3747](https://github.com/tahowallet/extension/suites/26032567144/artifacts/1703810792) (as of Mon, 15 Jul 2024 21:35:33 GMT).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node12 has been out of support since April 2022. As a result GH has started the deprecation process of Node12 for GitHub Actions by migrating all actions to run on Node16 (read
more). The
softprops/action-gh-releaseaction's version which we used in thebuild.ymlworkflow was running on Node12. But a newer version (v0.1.15) of the action is run on Node16. We're swithing to using that newer version. This should makeThe following actions uses node12 which is deprecated and will be forced to run on node16: softprops/action-gh-release@1e07f4...annotation disappear from the details of the workflow runs.The upgrade may also remove the
The "set-output" command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/annotation.Latest build: extension-builds-3722 (as of Sat, 13 Apr 2024 18:02:51 GMT).